Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font chooser lags a lot #18

Open
soumyaDghosh opened this issue Jan 31, 2024 · 6 comments
Open

Font chooser lags a lot #18

soumyaDghosh opened this issue Jan 31, 2024 · 6 comments

Comments

@soumyaDghosh
Copy link
Contributor

The font-chooser portal in the snap is kind of unusable and takes long to load.

Kooha-2024-01-31-12-47-45.mp4
@sergio-costas
Copy link
Contributor

I compared it with the .deb version, and it seems to happen the same: trying to move the vertical scroll is glitchy. Maybe this should be reported upstream...

@soumyaDghosh
Copy link
Contributor Author

soumyaDghosh commented Jan 31, 2024

I tried to look into the source-code... and probably this is the culprit.

https://gitlab.gnome.org/GNOME/gnome-text-editor/-/blob/main/src/editor-preferences-font.c#L74

This GtkFontChooserDialog is deprecated and replaced with GtkFontDialog.

@sergio-costas
Copy link
Contributor

I see... maybe it is. Changing to GtkFontDialog seems not very complex, just creating one, calling gtk_font_dialog_choose_font(), and in the callback, get the PangoFontDescription object and use toString.

@soumyaDghosh
Copy link
Contributor Author

@sergio-costas
Copy link
Contributor

Great! I'll prepare a patch for this. Thanks!

@sergio-costas
Copy link
Contributor

I prepared a MR with that, but doesn't seem to fix the problem... Can you test it? #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants