[Extend] version-automation to rockcraft.yaml
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergio-costas, pls review this PR also |
|
@sergio-costas, any update on this PR? |
|
Sorry, didn't receive the notification. I'll check it now. |
sergio-costas
requested changes
Jul 1, 2024
| @@ -62,6 +62,32 @@ def process_snap_version_data(upstreamversion, snap_name, version_schema, has_up | |||
| return f"{upstreamversion}-{packagerelease}" | |||
|
|
|||
|
|
|||
| def process_rock_version_data(upstreamversion, prevversion, version_schema, has_update): | |||
There was a problem hiding this comment.
upstream_version and previous_version
| return None | ||
| upstreamversion = match.group(1).replace('_', '.') | ||
|
|
||
| def version_tuple(v): |
There was a problem hiding this comment.
Do we really need to create a function just for this?
There was a problem hiding this comment.
Removed function and now using inline tuple to resolve version
… tuple map function
sergio-costas
requested changes
Jul 1, 2024
| def version_tuple(v): | ||
| return tuple(map(int, v.split('.'))) | ||
|
|
||
| upstream_tuple = version_tuple(upstream_version) |
There was a problem hiding this comment.
Ehm... Is this a problem in github, or the function is really still there?
There was a problem hiding this comment.
Sorry I forgot to remove that functions... Now fixed it
|
Thanks for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended
desktop-snapto supportversion automationinrockraft.yamlalso.rock-version-schema, and all other rules will follow as insnap, such as:metadata, and theleading upstream componentshould be defined in theadopt-infosection.<upstream-version>-<package-release>.