Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add appstream results to autocompletion #1372

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Sep 13, 2023

UDENG-1364
Ref #1367

Screenshot from 2023-09-13 15-06-44

@tim-hm when running this in debug mode loading the appstream metadata slows down the app drastically to the point where the UI becomes unresponsive for a short time. This should be hardly noticeable in release mode, though. However, there's some delay before the appstream autocompletion results become available - we should cache the metadata pool in a format that can be loaded more quickly later on.

I had to refactor the search providers a bit:

  • src/search now only contains the common search logic (i.e. the search query and the autocompletion provider
  • src/appstream and src/snapd now have their own separate search providers - there's no common filtering and sorting logic yet.

@d-loose d-loose requested a review from tim-hm September 13, 2023 15:24
lib/main.dart Show resolved Hide resolved
@tim-hm
Copy link

tim-hm commented Sep 14, 2023

A few bits for your consideration! Go ahead and merge when you're happy.

test: update search_field_test

refactor: race futures in autoCompleteProvider

docs: clarify autoCompleteProvider behavior

docs: comment on unawaited future appstream.init()

feat: add logger
@d-loose d-loose merged commit 6c5e11b into ubuntu:dev Sep 14, 2023
6 checks passed
tim-hm pushed a commit that referenced this pull request Sep 19, 2023
test: update search_field_test

refactor: race futures in autoCompleteProvider

docs: clarify autoCompleteProvider behavior

docs: comment on unawaited future appstream.init()

feat: add logger
@d-loose d-loose deleted the appstream-autocompletion branch September 19, 2023 21:01
ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
test: update search_field_test

refactor: race futures in autoCompleteProvider

docs: clarify autoCompleteProvider behavior

docs: comment on unawaited future appstream.init()

feat: add logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants