-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly install/refresh classic snaps #1350
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add detail page
chore: setup CI
chore: set up build_runner
feat(detail): add button to install/remove snap
feat: add ManagePage (list of local snaps)
Bumps [yaru](https://github.com/ubuntu/yaru.dart) from 0.7.0 to 0.9.0. - [Release notes](https://github.com/ubuntu/yaru.dart/releases) - [Changelog](https://github.com/ubuntu/yaru.dart/blob/main/CHANGELOG.md) - [Commits](https://github.com/ubuntu/yaru.dart/commits/v0.9.0) --- updated-dependencies: - dependency-name: yaru dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
chore(deps): bump yaru from 0.7.0 to 0.9.0
* add l10n strings * implement manage page design * update manage page test * make only icon and title clickable * more l10n strings * add loading state to updates model * only listen to changes of refreshableSnaps in ManageModel * refactor manage page; add refresh button * update tests + mocks
* add ResponsiveLayoutType * implement layout for small screen size
* feat: add 'show details' action to manage page Just a single item in the dropdown for the MVP * simplify 'onPressed'
This seems to cause problems with the autocompletion - let's revert this for now and come back to it in case caching too many searches causes any issues in the future.
* feat: generalize search routes to include category * feat: generalize search page
* feat: add 'snap://' argument handler * improve code legibility
* update l10n strings * fix: actually use SafeNetworkImage's parameters * add SnapImageCard * add SnapImageCardGrid * add 'gaming' snap cards to explore page
* feat: import @Zoospora's banner gradients * add todo
* add l10n strings * add button to banner * hide banner icons in small layout * add todo notes
* move snap l10n extensions into separate file * show change progress in 'update all' button * update tests, leave todo notes * add 'updating' l10n string * re-use updatesModel
* add l10n strings * add 'hidden' property to SnapCategoryEnum * add category dropdown to search page * generalize mockSearchProvider * test category search * simplify 'hidden' property
* Fix launchpad builds work around pub get stack overflow # dart-lang/sdk#51068 (comment) * Set -eux after pub get
Note that the gtk window currently needs to be 52px larger in both directions to account for the shadow from libhandy.
* add getStoreSnaps * add 'ubuntuDesktop' category * add custom featured snaps * return featured snaps in searchProvider for hidden categories * update explore page * todo: deprecate old categoryProvider * make mock search provider return a stream * test getStoreSnaps * update mocks * add documentation to getStoreSnaps * check explicitly for ubuntuDesktop in searchProvider
* refactor: remove category page * read cached category when search query is empty
* add l10n strings * show message if search results are empty * test empty search page * fix empty search logic * fix typo
* generalize SnapSortOrder * add local_snap_providers (sorting+filtering) * add sorting and filtering to manage page
* add missing l10n string * fix featured productivity snaps * remove obsolete explore provider * update explore page * add comments
superseded by #1352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDENG-1304
close #1348