Settings: Sources

[madsrh]

The current sources list looks very cluttered. I know this is a very low priority, but I just wanted to share a suggestion ☺️

Current:

When looking at how this currently works in Software & Updates, I think we can cleanup the very long string. Because of issue https://github.com/ubuntu-flutter-community/software/issues/841 I've added a trash can, but maybe adding the three dots icon (kebab) would be better if we want to add more options like this dialog.

Mockup:

[Feichtmeier]

yeah it was a quick thing, you are right this needs love

eventually we could use a real flutter table for this? I don't have much experience in using them but I can look how @jpnurmi did it in the installer

[Feichtmeier]

( with package kit it is sadly not possible to remove those entries by the way, maybe this needs a custom solution or we could make it work with apt.dart )

[anasereijo]

Pasting here @local-optimum's issue, so it doesn't get lost:

Before considering the below @anasereijo it would be good to work with Elio around the relationship between Software & Updates and this screen, whilst we may ultimately want to consolidate some of the features of that app into the Ubuntu Software store, it may be preferable in the meantime to have the Sources link actually simply open the correct tab on Software & Updates rather than replicate it (with my below feedback then being saved for a future release)

• It would be good to include more helpful context on syntax for adding repos/ppas matching the software & updates style
  

• The sources list could likely be reduced in font size for easier readability, compare with the same list in Software & Updates for the relative compactness

compared to:

For consistency we should also right align the checkboxes.

• Software & Updates also includes the signing key in a separate section, we may want to consider incorporating this as well if possible.

[Feichtmeier]

Problem is packagekit only throws out

/// An event from the backend to describe a repository on the system.
class PackageKitRepositoryDetailEvent extends PackageKitEvent {
  /// The ID of the repository.
  final String repoId;

  /// A description of the repository.
  final String description;

  /// True if the repository is enabled an in use.
  final bool enabled;

so if we want the url we could play with regex

ListTile(
                        title: Builder(
                          builder: (context) {
                            RegExp exp = RegExp(
                              r'(?:(?:https?|ftp):\/\/)?[\w/\-?=%.]+\.[\w/\-?=%.]+',
                            );
                            Iterable<RegExpMatch> matches =
                                exp.allMatches(e.repoId);

                            String url = '';

                            for (var match in matches) {
                              url = e.repoId.substring(match.start, match.end);
                            }
                            return Text(
                              url,
                            );
                          },
                        ),
                        subtitle: Text(e.description),
                      )

but I don't know how to get the other infos.
Maybe we could improve this in packagekit.dart ?

CC @d-loose

[d-loose]

but I don't know how to get the other infos.

Which other infos? the repoId contains the entire entry from the sources.list, including the signing key, if specified.

[Feichtmeier]

okay, but it needs to sucked out of the string then. would be cool if this could be done inside packagekit instead of regex kung fu IMO

[d-loose]

I think we want to keep the DBus client library as plain as possible and simply expose the DBus API without any additional parsing