Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove/change all unity8 references with lomiri or other string #338

Open
Aury88 opened this issue Sep 7, 2020 · 3 comments
Open

remove/change all unity8 references with lomiri or other string #338

Aury88 opened this issue Sep 7, 2020 · 3 comments

Comments

@Aury88
Copy link
Contributor

Aury88 commented Sep 7, 2020

all the documentation talk about unity8 instead of lomiri, also all the libraries with old ubuntuish name probably need to be updated to newer one.

so probably is needed a list of name changes like [oldname1]->[newname1], [oldname2]->[newname2]
also the changing procedure probably can be done instantaneously with appropriate sedcommand ...something like sed -i 's/[oldname]/[newname]/g' *

@doniks
Copy link
Collaborator

doniks commented Sep 8, 2020

You don't happen to feel the inspiration to be the one to fix it with a pr maybe :D ... just asking

@Aury88
Copy link
Contributor Author

Aury88 commented Sep 13, 2020

@doniks I still don't feel very comfortable using git, I only changed single file per pr until now while this change need a local "fork " but I can try and that was my intention .
I opened this issue to know all the needed [oldname]->[newname] changes before modify any string and propose a pr

@Aury88
Copy link
Contributor Author

Aury88 commented Sep 14, 2020

ok while waiting instructions for the needed string changes I checked the local clone and found this:

$ grep -o -R "unity*" *  | wc -l
595
$ grep -o -R "unity" *  | wc -l
337
$ grep -o -R "unity " *  | wc -l
168
$ grep -o -R "unity7" *  | wc -l
0
$ grep -o -R "unity8" *  | wc -l
15
$ grep -o -R "ubuntu" *  | wc -l
2041
$ grep -o -R "canonical" *  | wc -l
31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants