Reimplement Tracking Code #74
Assignees
Comments
|
/start |
![UbiquiBot[dev]](https://avatars.githubusercontent.com/in/257883?s=40&u=1eea9b595c7c8aa1f9dd80751aa25f169024431e&v=4){kind=avatar}
Tips:
|
Tips:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/start |
|
We could detect if adblock is used in js code and (for example) block the whole UI of the https://work.ubq.fi/ with a warning messages like |
|
I think that degrades the UX so I am not onboard with that approach. |
|
/start |
! You have reached your max task limit. Please close out some tasks before assigning new ones. |
Also there are ways to bypass js page blockers. |
|
Should I use Supabase for storage? |
@gentlementlegen @Keyrxng Do we still use supabase for such kind of tasks for saving a map of |
There is a difference between |
|
Seems like overkill to use Supabase for this. What is the easiest to implement out of the following three?
|
Since this issue requires a backend and we host all backend-related code in cloudflare functions it seems that it's better to stick to cloudflare KV. As far as I understand we need a single mapping of |
! You have reached your max task limit. Please close out some tasks before assigning new ones. |
|
I'll refer @koya0 for this one |
|
/wallet 0xd4c680d58b9c370ed810523C83B8Ec3cD66a694f |
+ Successfully registered wallet address |
|
/start |
Tip
|
|
@0x4007 How have you guys currently set up cloudflare KV and auth? I need a reference on how to integrate with your current setup. If I need to create a new DB instance I was wondering if an auth header is fine for authentication. I haven't worked with KV before so I'd appreciate any enlightnment regarding this step of the issue. |
|
I think you just set up your own KV and then we deploy the same config to ours later Maybe @whilefoo and @gentlementlegen can add more detail |
|
For the auth, we use Supabase. You would need Docker to run it locally, you can also create a free account and have an online instance. For KV, you can either create a free Cloudflare account, or same as Supabase you can run the kernel locally. https://github.com/ubiquity-os/ubiquity-os-kernel |
|
@0x4007 @rndquu @koya0 This is probably the latest supabase setting
|
@zugdev is right, I wasn't able to test the tracker in my Cloudflare Page using the supabase current settings. After the auth, I was being redirected to Hopefully @zugdev sent me a supabase he set, and allowed the url from my page, after that, I was able to test the tracker and, it's working. |
|
I think it should be the default URL actually. Its cleaner than work.ubq.fi |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 800 |
| Issue | Comment | 2 | 5.398 |
| Review | Comment | 19 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
@0x4007 How have you guys currently set up cloudflare KV and aut… | 3.38content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 63
wordValue: 0.1
result: 3.38
| 0.7 | 2.366 |
@zugdev is right, I wasn't able to test the tracker in my Cloudf… | 3.79content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 72
wordValue: 0.1
result: 3.79
| 0.8 | 3.032 |
Resolves #74 | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.8 | 0 |
You want to make sure that we handle the request, only if the us… | 2.66content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.2
result: 2.66
| 0.6 | 0 |
I guess you didn't see the most recent commit I made for validat… | 14.5content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 39
wordValue: 0.2
result: 4.5
| 0.9 | 0 |
the type of the request I get here: `const { request, env } … | 3.91content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 33
wordValue: 0.2
result: 3.91
| 0.7 | 0 |
I was using the first one to handle the json parsing, but I will… | 2.11content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.2
result: 2.11
| 0.5 | 0 |
Oh sorry, probably when I tried to use `Request` the imp… | 4.01content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 34
wordValue: 0.2
result: 4.01
| 0.7 | 0 |
the code I used for the worker was this js file:```… | 4.99content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 44
wordValue: 0.2
result: 4.99
| 0.8 | 0 |
I also made a quick demo of the tracker workinghttps://github.… | 2.66content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 21
wordValue: 0.2
result: 2.66
| 0.4 | 0 |
you can login in the [page I deployed](work-ubq-fi-d8j.pages.dev… | 26.45content:
content:
p:
score: 0
elementCount: 4
a:
score: 5
elementCount: 3
result: 15
regex:
wordCount: 117
wordValue: 0.2
result: 11.45
| 0.75 | 0 |
got it!![image](https://github.com/user-attachments/assets/992… | 5.36content:
content:
p:
score: 0
elementCount: 2
img:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 2
wordValue: 0.2
result: 0.36
| 0.3 | 0 |
@0x4007 @whilefoo have you already tested? What should be done n… | 2.55content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 20
wordValue: 0.2
result: 2.55
| 0.5 | 0 |
https://github.com/ubiquity/work.ubq.fi/blob/6f5fa3ee34d66c2dcc7… | 5.84content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 53
wordValue: 0.2
result: 5.84
| 0.9 | 0 |
That's fine! But, I thought @0x4007 wanted me to remove that, wh… | 14.7content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 41
wordValue: 0.2
result: 4.7
| 0.4 | 0 |
I fixed the conflicts, but I'm not sure what start command you a… | 2.44content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.2
result: 2.44
| 0.4 | 0 |
![image](https://github.com/user-attachments/assets/d76cc0be-c1b… | 6.65content:
content:
p:
score: 0
elementCount: 2
img:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 12
wordValue: 0.2
result: 1.65
| 0.3 | 0 |
when I ran yarn install, the file didn't change | 1.42content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0.2
result: 1.42
| 0.2 | 0 |
I'm running with yarn 3.6.3, what is your version? | 1.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.2
result: 1.65
| 0.3 | 0 |
@whilefoo I changed my yarn to v1.22.22 and updated the yarn.loc… | 2.55content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 20
wordValue: 0.2
result: 2.55
| 0.8 | 0 |
I was having problems deploying the page with workers, because t… | 4.6content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 40
wordValue: 0.2
result: 4.6
| 0.7 | 0 |
[ 43.9845 UUSD ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 18.06 |
| Issue | Comment | 4 | 21.8735 |
| Review | Comment | 11 | 4.051 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Due to the ad blockers, the google analytics reliant version of … | 6.02content:
content:
p:
score: 0
elementCount: 5
ul:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 4
result: 3
regex:
wordCount: 55
wordValue: 0.1
result: 3.02
| 1 | 18.06 |
I think that degrades the UX so I am not onboard with that appro… | 1.88content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.2
result: 1.88
| 0.6 | 1.128 |
Seems like overkill to use Supabase for this. What is the easies… | 9.09content:
content:
p:
score: 0
elementCount: 4
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 3
result: 2.5
regex:
wordCount: 61
wordValue: 0.2
result: 6.59
| 0.75 | 7.4425 |
I think you just set up your own KV and then we deploy the same … | 3.29content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 27
wordValue: 0.2
result: 3.29
| 0.7 | 2.303 |
![image](https://github.com/user-attachments/assets/dff0fa14-911… | 12content:
content:
p:
score: 0
elementCount: 1
img:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 15
wordValue: 0.2
result: 2
| 0.5 | 11 |
Commit TypeScript not JavaScript and run formatting | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.5 | 0.26 |
Code looks good. How do we test? | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.3 | 0.156 |
Looks like you now have two lock files. Is that correct? Actuall… | 1.54content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 25
wordValue: 0.1
result: 1.54
| 0.2 | 0.308 |
Be sure to run `yarn format` | 0.32content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 4
wordValue: 0.1
result: 0.32
| 0.4 | 0.128 |
I think we should remove support for the old code. We don't need… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.8 | 0.8 |
Remove the old support here too. | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.7 | 0.322 |
Using terms like "tracker" will definitely get blocked by ad blo… | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 1 | 0.77 |
These seem like they should be secrets? | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.6 | 0.312 |
Check the beta branch of pay.ubq.fi repo to see how we committed… | 2.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 39
wordValue: 0.1
result: 2.25
| 0.2 | 0.45 |
I use yarn 1.22.21 and don't have these problems. | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.1 | 0.083 |
We use node 20.10.0 across all our CII suppose it might make se… | 1.54content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 25
wordValue: 0.1
result: 1.54
| 0.3 | 0.462 |
[ 3.1125 UUSD ]
@gentlementlegen
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 3.1125 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
For the auth, we use Supabase. You would need Docker to run it l… | 4.15content:
content:
p:
score: 0
elementCount: 5
result: 0
regex:
wordCount: 80
wordValue: 0.1
result: 4.15
| 0.75 | 3.1125 |
[ 0.594 UUSD ]
@Keyrxng
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 1 | 0.594 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
The org uses `[email protected]` in 95% of repos, there are a se… | 2.97content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 54
wordValue: 0.1
result: 2.97
| 0.2 | 0.594 |
[ 4.95 UUSD ]
@rndquu
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 4 | 4.95 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
We could detect if adblock is used in js code and (for example) … | 2.4content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 42
wordValue: 0.1
result: 2.4
| 0.4 | 0.96 |
@gentlementlegen @Keyrxng Do we still use supabase for such kind… | 1.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 27
wordValue: 0.1
result: 1.65
| 0.75 | 1.2375 |
There is a difference between `js blocker + google analytics… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0.6 | 0.636 |
Since this issue requires a backend and we host all backend-rela… | 2.49content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 44
wordValue: 0.1
result: 2.49
| 0.85 | 2.1165 |
[ 4.11625 UUSD ]
@zugdev
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 4 | 2.09675 |
| Review | Comment | 8 | 2.0195 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Also there are ways to bypass js page blockers. | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0.6 | 0.095 |
Should I use Supabase for storage? | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.8 | 0.097 |
I'll refer @koya0 for this one | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.4 | 0.052 |
@0x4007 @rndquu @koya0 `work.ubq.fi` is redirecting to &… | 7.69content:
content:
p:
score: 0
elementCount: 3
img:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 48
wordValue: 0.1
result: 2.69
| 0.9 | 1.85275 |
I believe it's best if you commit this, perhaps `cloudflare-… | 0.71content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0.1
result: 0.71
| 0.2 | 0.038 |
You should remove the `?ref` parameter from the URL afte… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.9 | 0.225 |
I have tried it, please send screenshot proving my ref was captu… | 1.28content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 20
wordValue: 0.1
result: 1.28
| 0.1 | 0.032 |
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to the ad blockers, the google analytics reliant version of the devrel tracker is not reliable. We will need to fully redo this feature. Likely will need to be fully custom so this requires storage on the backend.
ref=The text was updated successfully, but these errors were encountered: