From 0b97b0ee2575d757de01992f2cd9bb0d2d08e023 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=A2=E3=83=AC=E3=82=AF=E3=82=B5=E3=83=B3=E3=83=80?= =?UTF-8?q?=E3=83=BC=2Eeth?= Date: Wed, 9 Oct 2024 06:15:21 +0900 Subject: [PATCH] feat: no empty strings --- .github/workflows/no-empty-strings.yml | 71 ++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 .github/workflows/no-empty-strings.yml diff --git a/.github/workflows/no-empty-strings.yml b/.github/workflows/no-empty-strings.yml new file mode 100644 index 0000000..41f1f1c --- /dev/null +++ b/.github/workflows/no-empty-strings.yml @@ -0,0 +1,71 @@ +name: Check for Empty Strings + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + check-empty-strings: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Get GitHub App token + uses: tibdex/github-app-token@v1.7.0 + id: get_installation_token + with: + app_id: ${{ secrets.APP_ID }} + private_key: ${{ secrets.APP_PRIVATE_KEY }} + + - name: Find empty strings + id: find-empty-strings + run: | + # Get the base branch (usually main or master) + BASE_BRANCH=$(gh pr view ${{ github.event.pull_request.number }} --json baseRefName --jq .baseRefName) + + # Get the list of changed files in the PR + CHANGED_FILES=$(gh pr diff ${{ github.event.pull_request.number }} --name-only) + + # Initialize empty string for results + EMPTY_STRINGS="" + + # Loop through changed files + for file in $CHANGED_FILES; do + if [[ $file =~ \.(ts|tsx)$ ]]; then + # Get the diff for this file + DIFF=$(gh pr diff ${{ github.event.pull_request.number }} --color never -- $file) + + # Find added lines with empty strings + ADDED_EMPTY=$(echo "$DIFF" | grep -n "^+" | grep -E "(''{2}|\"\"{2})" | sed "s/^+//g" | sed "s/^/${file}:/") + + # Append results + if [ ! -z "$ADDED_EMPTY" ]; then + EMPTY_STRINGS+="$ADDED_EMPTY"$'\n' + fi + fi + done + + # Output results + echo "EMPTY_STRINGS<> $GITHUB_OUTPUT + echo "$EMPTY_STRINGS" >> $GITHUB_OUTPUT + echo "EOF" >> $GITHUB_OUTPUT + env: + GH_TOKEN: ${{ steps.get_installation_token.outputs.token }} + + - name: Comment on PR + uses: actions/github-script@v6 + if: steps.find-empty-strings.outputs.EMPTY_STRINGS + with: + github-token: ${{ steps.get_installation_token.outputs.token }} + script: | + const emptyStrings = process.env.EMPTY_STRINGS.trim().split('\n'); + if (emptyStrings.length > 0) { + const body = `### Empty Strings Found\n\nPlease review the following lines containing empty strings:\n\n${emptyStrings.map(line => `- \`${line}\``).join('\n')}`; + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.name, + body: body + }); + }