Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a runs_on section to the configuration and the manifests #73

Closed
gentlementlegen opened this issue Jul 11, 2024 · 10 comments · Fixed by #74
Closed

Add a runs_on section to the configuration and the manifests #73

gentlementlegen opened this issue Jul 11, 2024 · 10 comments · Fixed by #74

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Jul 11, 2024

We will have a runs_on item that will describe which events the plugin will be subscribed to, according to the following discussion.

Expected format:

  • on the manifest side:
{
  "name": "query-user",
+ "ubiquity:runsOn": [ "issues.opened", "issues.closed" ]
}
  • on the configuration side:
plugins:
- 'issues.opened':
  - uses:
     - plugin: org/query-user
+      runsOn: [ 'issues.opened' ]

The configuration takes over the manifest is present, otherwise the manifest is the default.

Copy link

ubiquibot bot commented Jul 12, 2024

@gentlementlegen, You are not allowed to add Time: <4 Hours

Copy link

ubiquibot bot commented Jul 12, 2024

! No permission to set labels

@0x4007
Copy link
Member

0x4007 commented Jul 12, 2024

runsOn Camel case seems unexpected. What about snake case as I've seen in the manifest standard.

Or better, consider a one word solution like subscribe, invoke, listener (reference to event listener)

Some other interesting syntax:

"plugin:addEventListener": [ ... ]

Also isn't uses: superfluous?

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jul 12, 2024

Let's make it plural as it is a list, I propose subscriptions or listeners then.

Isn't "plugin:addEventListener" camel case as well?

uses is because you can have other properties such as name, id, description that I didn't list in the spec because not relevant, and because it is an array.

@gentlementlegen
Copy link
Member Author

Copy link

ubiquibot bot commented Jul 24, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot-dev bot commented Jul 24, 2024

[ 119.56 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 100
Issue Specification 1 9.9
Issue Comment 2 9.66
Conversation Incentives
Comment Formatting Relevance Reward
We will have a `runs_on` item that will describe which e…
9.9
content:
  p:
    count: 73
    score: 1
  code:
    count: 26
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 9.9
Let's make it plural as it is a list, I propose `subscriptio…
11.4
content:
  p:
    count: 50
    score: 1
  code:
    count: 7
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 9.12
When closed, the following configurations should be updated: htt…
1.8
content:
  p:
    count: 9
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.3 0.54

[ 4.165 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 4.165
Conversation Incentives
Comment Formatting Relevance Reward
`runsOn` Camel case seems unexpected. What about snake c…
4.9
content:
  p:
    count: 43
    score: 1
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.85 4.165

Copy link

ubiquibot bot commented Jul 24, 2024

[ 7.7 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment17.3
ReviewComment10.4
Conversation Incentives
CommentFormattingRelevanceReward
`runsOn` Camel case seems unexpected. What about snake c...
7.3
code:
  count: 3
  score: "3"
  words: 6
0.637.3
@gentlementlegen yes merge them....
0.40.080.4

[ 204.9 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification118.2
IssueTask1100
IssueComment224
IssueComment20
ReviewComment441.8
ReviewComment420.9
Conversation Incentives
CommentFormattingRelevanceReward
We will have a `runs_on` item that will describe which e...
18.2
li:
  count: 2
  score: "2"
  words: 8
code:
  count: 3
  score: "3"
  words: 1
118.2
Let's make it plural as it is a list, I propose `subscriptio...
17.8
code:
  count: 7
  score: "7"
  words: 10
0.7517.8
When closed, the following configurations should be updated: ht...
6.20.556.2
Let's make it plural as it is a list, I propose `subscriptio...
-
code:
  count: 7
  score: "0"
  words: 10
0.75-
When closed, the following configurations should be updated: ht...
-0.55-
For this PR to work properly, all the related manifest pull-requ...
5.40.155.4
> @gentlementlegen Check [this](https://github.com/rndquu-org...
17.6
a:
  count: 3
  score: "6"
  words: 5
code:
  count: 3
  score: "6"
  words: 8
0.6117.6
@rndquu The issue was that the `hello-world` plugin woul...
15
code:
  count: 1
  score: "2"
  words: 2
0.7815
@rndquu Thank you for the remark, created a ticket for it: https...
3.80.613.8
For this PR to work properly, all the related manifest pull-requ...
2.70.152.7
> @gentlementlegen Check [this](https://github.com/rndquu-org...
8.8
a:
  count: 3
  score: "3"
  words: 5
code:
  count: 3
  score: "3"
  words: 8
0.618.8
@rndquu The issue was that the `hello-world` plugin woul...
7.5
code:
  count: 1
  score: "1"
  words: 2
0.787.5
@rndquu Thank you for the remark, created a ticket for it: https...
1.90.611.9

[ 21.1 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment321.1
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen Check [this](https://github.com/rndquu-org/test...
8.5
a:
  count: 3
  score: "3"
  words: 5
code:
  count: 2
  score: "2"
  words: 7
0.38.5
@gentlementlegen Check [this](https://github.com/rndquu-org/test...
8.4
a:
  count: 4
  score: "4"
  words: 5
code:
  count: 1
  score: "1"
  words: 1
0.728.4
> @rndquu The issue was that the `hello-world` plugin...
4.2
code:
  count: 1
  score: "1"
  words: 2
0.654.2

@0x4007
Copy link
Member

0x4007 commented Jul 24, 2024

@gentlementlegen Review comments aren't taken into account

@gentlementlegen
Copy link
Member Author

@0x4007 Same issue as usual, will also link to ubiquity-os-marketplace/text-conversation-rewards#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants