Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive setup #171

Closed
whilefoo opened this issue Oct 27, 2024 · 36 comments · Fixed by #198
Closed

Interactive setup #171

whilefoo opened this issue Oct 27, 2024 · 36 comments · Fixed by #198

Comments

@whilefoo
Copy link
Contributor

The goal of this task is to simplify developer experience when setting up the kernel.
To do this we need to create an interactive CLI tool that will help with setting up the Github App and preparing Cloudflare for deployment of the kernel

This setup tool should be inspired by Probot's setup flow

1. Setup Cloudflare and Wrangler

  • Make the user login with Wrangler
  • Create a KV namespace and put the ID in wrangler.toml (we already have a script that can be used and/or modified)

2. GitHub App Setup Automation

This can be done with Github App Manifest

  • Automate creation of a GitHub App
  • Subscribe to all required GitHub events
  • Set necessary permissions for the App
  • Convert the private key to PKCS#8
  • Populate App ID, private key and webhook secret into .dev.vars file and in Cloudflare Worker secrets.

Additionally we can make an option in the SDK to disable signature verification in order to ease the development of new plugins.

@0x4007
Copy link
Member

0x4007 commented Oct 27, 2024

Time estimate please

@whilefoo
Copy link
Contributor Author

I think a week would be fine

@zugdev
Copy link

zugdev commented Nov 1, 2024

@vichydra 👀

Copy link

! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@hhio618
Copy link

hhio618 commented Nov 2, 2024

/start

Copy link

Deadline Sat, Nov 9, 3:25 PM UTC
Beneficiary 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

Passed the deadline and no activity is detected, removing assignees: @hhio618.

@vichydra
Copy link

vichydra commented Nov 3, 2024

/start

@0x4007
Copy link
Member

0x4007 commented Nov 3, 2024

/start

This again @gentlementlegen 👀

Copy link

@vichydra the deadline is at Sun, Nov 10, 4:20 PM UTC

Copy link

A new workroom has been created for this task. Join chat

Copy link

Passed the deadline and no activity is detected, removing assignees: @vichydra.

@Keyrxng
Copy link
Member

Keyrxng commented Nov 5, 2024

@0x4007 You can check the logs: https://dash.cloudflare.com/5c0228bee348f4cf48829ffe21b61fe9/workers/services/view/ubiquity-os-kernel-development/production/observability/logs?granularity=0&time=%7B%22type%22%3A%22absolute%22%2C%22to%22%3A1730648160000%2C%22from%22%3A1730648040000%7D

The fetch hung and failed from Cloudflare when invoking the plugin.

Tail workers seem like a solid solution to this sort of thing.

One worker to catch all exceptions in other workers; it could then ping via TG the exception that happened, where, when, who and how straight into a private chat filled with proactive trusted contributors.

Requires a paid plan, something we have avoided but eventually we are going to have to bite that bullet I think.

@0x4007
Copy link
Member

0x4007 commented Nov 5, 2024

@0x4007 You can check the logs: https://dash.cloudflare.com/5c0228bee348f4cf48829ffe21b61fe9/workers/services/view/ubiquity-os-kernel-development/production/observability/logs?granularity=0&time=%7B%22type%22%3A%22absolute%22%2C%22to%22%3A1730648160000%2C%22from%22%3A1730648040000%7D

The fetch hung and failed from Cloudflare when invoking the plugin.

It's too tedious to do from mobile unfortunately

@whilefoo
Copy link
Contributor Author

whilefoo commented Nov 8, 2024

/start

Copy link

Deadline Fri, Nov 15, 9:18 PM UTC
Beneficiary 0xA0B11F474d8ECE1205d38c66d5F2bE8917675d60

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@ariesgun
Copy link

ariesgun commented Nov 8, 2024

/start

Copy link

! This issue is already assigned. Please choose another unassigned task.

Copy link

Passed the deadline and no activity is detected, removing assignees: @whilefoo.

@zugdev
Copy link

zugdev commented Nov 10, 2024

@whilefoo can I start on this one?

@whilefoo
Copy link
Contributor Author

@whilefoo can I start on this one?

sorry, I'm already working on it, deadlines seem to be broken so maybe you can solve that task?

Copy link

! whilefoo you were previously unassigned from this task. You cannot be reassigned.

@henalolp
Copy link

/help

Copy link

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label. /allow @user1 label
/query Returns the user's wallet, access, and multiplier information. /query @UbiquityOS
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/wallet Register your wallet address for payments. /wallet ubq.eth

@henalolp
Copy link

/wallet 0x226AAE6Db84dca652818400750b8BF96a077349e

Copy link

+ Successfully registered wallet address

@henalolp
Copy link

/start

Copy link

Deadline Thu, Nov 21, 1:14 PM UTC
Beneficiary 0x226AAE6Db84dca652818400750b8BF96a077349e

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@whilefoo
Copy link
Contributor Author

@henalolp please note that this task is already done so you don't waste your time

@henalolp
Copy link

henalolp commented Nov 15, 2024

I was working on this task, and it says it is open. Should I have to abandon this task? 

@zugdev
Copy link

zugdev commented Nov 15, 2024

I was working on this task, and it says it is open. Should I have to abandon this task?

Whilefoo was asigned and has a pull open, #198, it was also clearly stated a couple comments above that he was actively working on this task and a little bug regards the disqualification plugin. I am sorry, but yes.

@henalolp
Copy link

ok

@0x4007 0x4007 assigned whilefoo and unassigned henalolp Nov 18, 2024
Copy link

@whilefoo the deadline is at Mon, Nov 25, 10:58 PM UTC

Copy link

+ Evaluating results. Please wait...

Copy link

 [ 1960.432 WXDAI ] 

@whilefoo
Contributions Overview
ViewContributionCountReward
IssueTask11600
IssueSpecification1337.08
IssueComment323.352
ReviewComment10
Conversation Incentives
CommentFormattingRelevancePriorityReward
The goal of this task is to simplify developer experience when s…
28.09
content:
  content:
    p:
      score: 0
      elementCount: 12
    a:
      score: 5
      elementCount: 3
    h3:
      score: 1
      elementCount: 2
    ul:
      score: 0
      elementCount: 2
    li:
      score: 0.5
      elementCount: 7
  result: 20.5
regex:
  wordCount: 163
  wordValue: 0.1
  result: 7.59
14337.08
I think a week would be fine
0.52
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.1
  result: 0.52
0.541.04
sorry, I'm already working on it, deadlines seem to be broken so…
6.22
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
0.3421.464
@henalolp please note that this task is already done so you don'…
1.06
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 16
  wordValue: 0.1
  result: 1.06
0.240.848
Resolves #171 Two new scripts- `setup.ts`: create a …
1
content:
  content:
    p:
      score: 0
      elementCount: 5
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
  result: 1
regex:
  wordCount: 95
  wordValue: 0
  result: 0
0.740

 [ 9.356 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment30
ReviewComment49.356
Conversation Incentives
CommentFormattingRelevancePriorityReward
Time estimate please
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
040
This again @gentlementlegen 👀
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
040
It's too tedious to do from mobile unfortunately
0.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 9
  wordValue: 0.1
  result: 0.65
040
Tested and it works well!
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.340.468
@gentlementlegen daemon-merge should take daemon-disqualifier in…
2.3
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 40
  wordValue: 0.1
  result: 2.3
0.847.36
@gentlementlegen this looks wrong
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
0.140.128
This is whilefoo pull request so it doesn't make sense to follow…
1.75
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 29
  wordValue: 0.1
  result: 1.75
0.241.4

 [ 2.52 WXDAI ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueComment32.52
Conversation Incentives
CommentFormattingRelevancePriorityReward
@vichydra 👀
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
040.02
@whilefoo can I start on this one?
0.52
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.1
  result: 0.52
0.540.26
Whilefoo was asigned and has a pull open, #198, it was also clea…
2.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 39
  wordValue: 0.1
  result: 2.25
142.24

 [ 16.056 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment110.92
ReviewComment25.136
Conversation Incentives
CommentFormattingRelevancePriorityReward
@0x4007 You can check the logs: https://dash.cloudflare.com/5c02…
2.73
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 49
  wordValue: 0.1
  result: 2.73
1410.92
@whilefoo might have been corrected in later wrangler versions, …
2.1
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 36
  wordValue: 0.1
  result: 2.1
0.544.2
@henalolp is currently the user assigned to the task so it makes…
1.17
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 18
  wordValue: 0.1
  result: 1.17
0.240.936

 [ 27.14 WXDAI ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueComment127.14
Conversation Incentives
CommentFormattingRelevancePriorityReward
[Tail workers](https://developers.cloudflare.com/workers/observa…
8.57
content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 67
  wordValue: 0.1
  result: 3.57
0.5427.14

 [ 1.31 WXDAI ] 

@henalolp
Contributions Overview
ViewContributionCountReward
IssueComment21.31
ReviewComment10
Conversation Incentives
CommentFormattingRelevancePriorityReward
I was working on this task, and it says it is open. Should I hav…
1.22
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
141.24
ok
0.1
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 1
  wordValue: 0.1
  result: 0.1
0.540.07
I have started working on the task and it is going well. But I w…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 38
  wordValue: 0
  result: 0
0.140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants