Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include review comments in the final result #61

Closed
gentlementlegen opened this issue Jul 17, 2024 · 4 comments
Closed

Include review comments in the final result #61

gentlementlegen opened this issue Jul 17, 2024 · 4 comments
Labels
Time: <2 Hours

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Jul 17, 2024 •
edited
Loading

Review comments seem to be ignored when collecting the result, as seen here:
#22

They should be included for all the users in the final result.

Another example of broken data:
ubiquity/rpc-handler#23 (comment)
@0x4007
Copy link
Member

0x4007 commented Jul 17, 2024 •
edited
Loading

Time estimate? Or perhaps we can make these rolling hotfix tasks official once they saturate a full day's of work?

@gentlementlegen
Copy link
Member Author

@0x4007 Added a time estimate. This was created to split the #26 which encapsulates all of the required fixes.

@gentlementlegen
Copy link
Member Author

This was fixed when shipping the v2 with all the changes.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Sep 24, 2024 

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Time: <2 Hours
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0x4007 @gentlementlegen