-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable permit gen for users in non collaborative issues #182
base: development
Are you sure you want to change the base?
Conversation
Please post QA and prove it works as expected |
Currently out for an university, will qa this issue in a few hours |
Qa is in progress please wait |
everything has been a mess since this pr got merged, tests not working resulting to it become weirdly hard to debug code |
ishowvel-org/.ubiquity-os#16 when issue closer is admin |
i hope for the tests to get fixed as this has caused me a magnitude of problems and headaches, waiting for workflows to run is not a good alternative to local test runs |
@0x4007 posted qa |
@gentlementlegen They claim your changes made this harder to test so you'll know best |
@ishowvel You can just merge the development branch here and you should not have any issues with the tests. |
test and qa both are passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems close but study the code elsewhere to see how we do logging and comments. They are formatted using our logger methods.
@ishowvel please delete the |
Done |
@ishowvel, this task has been idle for a while. Please provide an update. |
Just waiting for @gentlementlegen to review this |
To make sure this compiles, add |
heres the qa |
adding new tests |
Resolves #160