Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable permit gen for users in non collaborative issues #182

Open
wants to merge 19 commits into
base: development
Choose a base branch
from

Conversation

ishowvel
Copy link
Contributor

@ishowvel ishowvel commented Nov 7, 2024

Resolves #160

@0x4007
Copy link
Member

0x4007 commented Nov 8, 2024

Please post QA and prove it works as expected

@ishowvel
Copy link
Contributor Author

ishowvel commented Nov 9, 2024

Currently out for an university, will qa this issue in a few hours

@ishowvel
Copy link
Contributor Author

ishowvel commented Nov 9, 2024

Qa is in progress please wait

@ishowvel
Copy link
Contributor Author

everything has been a mess since this pr got merged, tests not working resulting to it become weirdly hard to debug code

@ishowvel
Copy link
Contributor Author

ishowvel-org/.ubiquity-os#16 when issue closer is admin
ishowvel-org/.ubiquity-os#17 when issue closer is not admin

@ishowvel
Copy link
Contributor Author

i hope for the tests to get fixed as this has caused me a magnitude of problems and headaches, waiting for workflows to run is not a good alternative to local test runs

@ishowvel
Copy link
Contributor Author

Please post QA and prove it works as expected

@0x4007 posted qa

@0x4007
Copy link
Member

0x4007 commented Nov 10, 2024

@gentlementlegen They claim your changes made this harder to test so you'll know best

@gentlementlegen
Copy link
Member

@ishowvel You can just merge the development branch here and you should not have any issues with the tests.

@ishowvel
Copy link
Contributor Author

@ishowvel
Copy link
Contributor Author

test and qa both are passing

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems close but study the code elsewhere to see how we do logging and comments. They are formatted using our logger methods.

src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
src/parser/permit-generation-module.ts Outdated Show resolved Hide resolved
@ishowvel ishowvel requested a review from 0x4007 November 12, 2024 07:19
@gentlementlegen
Copy link
Member

@ishowvel please delete the dist folder so the binary gets re-generated thanks.

@ishowvel
Copy link
Contributor Author

ease delete the dist folder so the binary gets re-generated thanks.

Done

Copy link

@ishowvel, this task has been idle for a while. Please provide an update.

@ishowvel
Copy link
Contributor Author

Just waiting for @gentlementlegen to review this

@gentlementlegen
Copy link
Member

To make sure this compiles, add "exclude": ["tests"] in tsconfig.json. Second, please add related unit tests to these changes.

@ishowvel
Copy link
Contributor Author

heres the qa
with reviews present ishowvel-org/.ubiquity-os#25
with no reviews present ishowvel-org/.ubiquity-os#27

@ishowvel ishowvel requested a review from 0x4007 November 19, 2024 06:33
@ishowvel
Copy link
Contributor Author

adding new tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only admin can generate rewards non collaboratively
3 participants