Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Better API for Case Insensitive String Equality Check #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

munahaf
Copy link

@munahaf munahaf commented Aug 15, 2023

In file: header_propagate.go, there is a function findField that performs a case insensitive String equality check. String comparison with strings.ToLower or strings.ToUpper is significantly more expensive. For example, strings.ToLower will have to allocate memory for the new strings, and then convert the string to lower case. It is better to do the case insensitive equality check using the strings.EqualFold(https://pkg.go.dev/strings#EqualFold) function. This function does not need to create two intermediate strings and can return as soon as the first non-matching character has been found. I fixed the issue by introducing the strings.EqualFold function.

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF)(https://openssf.org/): Project Alpha-Omega(https://alpha-omega.dev/). Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant