Deletes can have a body in rare circumstances, instead we will requir… #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e uses to annotate to assign fields as from query param
rpatali
reviewed
Apr 23, 2020
| @@ -254,7 +254,7 @@ func NewMethod( | |||
| method.setValidStatusCodes() | |||
|
|
|||
| if method.RequestType != "" { | |||
| hasNoBody := method.HTTPMethod == "GET" || method.HTTPMethod == "DELETE" | |||
| hasNoBody := method.HTTPMethod == "GET" | |||
There was a problem hiding this comment.
add a test by creating an endpoint in example-gateway that is a DELETE and has a request body.
There was a problem hiding this comment.
Good point, I added a test endpoint to exercise this path
argouber
approved these changes
Apr 23, 2020
…ing, scanning - part2 (#703) * parallelize endpoint gen, post gen hook, optimize loop * removing unnecessary reading of files repeatedly, optimize scanning * generate endpoint collection in a deterministic order * code fix to accomodate zanzibar user who has a different downstream converter * utilize parallel-go lib * transitive dep collection * closure param pass * parallelize factor
* parallelize resolve module
* support for system wide whitelisting of default headers we have a concept of default middleware, this is a same concept where we don't need a whitelist of headers per endpoint but rather a system-wide whitelist that will be always forwarded when available. These should be used for more of control plane kind of headers rather than application logic.
* export package.defaultHeaders field missed exporting the field in a previous PR# 709
* refactor write_json * Refactor write_json
* selectively generate module code
- fix the generated code - glide-up and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e uses to annotate to assign fields as from query param