You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We get some nice benefits e.g. automatic object releasing by ChannelHandlers ( which can bite you if you don't know it's happening! ), and a nicer API for releasing payloads e.g. RawRequest.release() instead of RawRequest.getArg1().release(); RawRequest.getArg2().release(); RawRequest.getArg2().release().
I had this implemented by wrapping the 3 contained ByteBufs in a CompositeByteBuf, but I wasn't sure about the retain/release semantics of CompositeBuffers vs. raw ByteBufs so I took out the logic. This isn't a perf. win, but may simplify retain/release APIs down the road.
The text was updated successfully, but these errors were encountered:
We get some nice benefits e.g. automatic object releasing by ChannelHandlers ( which can bite you if you don't know it's happening! ), and a nicer API for releasing payloads e.g.
RawRequest.release()
instead ofRawRequest.getArg1().release(); RawRequest.getArg2().release(); RawRequest.getArg2().release()
.I had this implemented by wrapping the 3 contained
ByteBuf
s in aCompositeByteBuf
, but I wasn't sure about the retain/release semantics of CompositeBuffers vs. rawByteBuf
s so I took out the logic. This isn't a perf. win, but may simplify retain/release APIs down the road.The text was updated successfully, but these errors were encountered: