Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Raw{Request,Response} ByteBufHolders #15

Open
willsalz opened this issue Aug 4, 2015 · 0 comments
Open

Make Raw{Request,Response} ByteBufHolders #15

willsalz opened this issue Aug 4, 2015 · 0 comments
Milestone

Comments

@willsalz
Copy link
Contributor

willsalz commented Aug 4, 2015

We get some nice benefits e.g. automatic object releasing by ChannelHandlers ( which can bite you if you don't know it's happening! ), and a nicer API for releasing payloads e.g. RawRequest.release() instead of RawRequest.getArg1().release(); RawRequest.getArg2().release(); RawRequest.getArg2().release().

I had this implemented by wrapping the 3 contained ByteBufs in a CompositeByteBuf, but I wasn't sure about the retain/release semantics of CompositeBuffers vs. raw ByteBufs so I took out the logic. This isn't a perf. win, but may simplify retain/release APIs down the road.

@willsalz willsalz added this to the v1 milestone Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant