This repository was archived by the owner on Mar 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 345
/
Copy pathbreaking_test.go
387 lines (379 loc) · 25.4 KB
/
breaking_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package breaking
import (
"testing"
"github.com/stretchr/testify/require"
"github.com/uber/prototool/internal/extract"
"github.com/uber/prototool/internal/reflect"
"github.com/uber/prototool/internal/settings"
ptesting "github.com/uber/prototool/internal/testing"
"github.com/uber/prototool/internal/text"
)
func TestRunOne(t *testing.T) {
testRun(
t,
"one",
false,
false,
newPackagesNotDeletedFailure("bar.v1"),
newPackagesNoBetaDepsFailure("foo.v1", "bar.v1beta1"),
newMessagesNotDeletedFailure("foo.v1.One.NestedOne.NestedNestedTwo"),
newMessagesNotDeletedFailure("foo.v1.One.NestedTwo"),
newMessagesNotDeletedFailure("foo.v1.Two"),
newMessageFieldsNotDeletedFailure("foo.v1.Three", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree.NestedNestedThree", 2),
newMessageFieldsSameTypeFailure("foo.v1.Four", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 3, "foo.v1.Four.NestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 3, "foo.v1.Four.NestedFour.NestedNestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour.SevenEntry", 1, "int64", "int32"),
newMessagesNotDeletedFailure("foo.v1.Five.FourEntry"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 1, "optional", "repeated"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 2, "optional", "repeated"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 2, "string", "message"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 3, "repeated", "optional"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 4, "repeated", "optional"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 4, "message", "int64"),
newEnumsNotDeletedFailure("foo.v1.EnumTwo"),
newEnumsNotDeletedFailure("foo.v1.Six.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSix.Foo"),
newMessagesNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSixDelete"),
newEnumValuesNotDeletedFailure("foo.v1.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 2),
newEnumValuesSameNameFailure("foo.v1.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight.NestedNestedEight", "test"),
newServicesNotDeletedFailure("foo.v1.TwoAPI"),
newServiceMethodsNotDeletedFailure("foo.v1.OneAPI", "OneTwo"),
newMessagesNotDeletedFailure("foo.v1.OneTwoRequest"),
newMessagesNotDeletedFailure("foo.v1.OneTwoResponse"),
newMessageFieldsSameNameFailure("foo.v1.Nine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine.NestedNestedNine", 1, "one", "two"),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen.NestedNestedTen", "test", 3),
newServiceMethodsSameRequestTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneRequest", "foo.v1.OneOneRequest"),
newServiceMethodsSameResponseTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneResponse", "foo.v1.OneOneResponse"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneRequest"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneResponse"),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeTwo", true),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeThree", false),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFour", true),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFive", false),
newMessageFieldsSameOneofFailure("foo.v1.Eleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven.NestedNestedEleven", 1, "test"),
)
}
func TestRunOneIncludeBeta(t *testing.T) {
testRun(
t,
"one",
true,
false,
newPackagesNotDeletedFailure("bar.v1"),
newPackagesNotDeletedFailure("foo.v1beta2"),
newMessagesNotDeletedFailure("foo.v1.One.NestedOne.NestedNestedTwo"),
newMessagesNotDeletedFailure("foo.v1.One.NestedTwo"),
newMessagesNotDeletedFailure("foo.v1.Two"),
newMessageFieldsNotDeletedFailure("foo.v1.Three", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree.NestedNestedThree", 2),
newMessageFieldsSameTypeFailure("foo.v1.Four", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 3, "foo.v1.Four.NestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 3, "foo.v1.Four.NestedFour.NestedNestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour.SevenEntry", 1, "int64", "int32"),
newMessagesNotDeletedFailure("foo.v1.Five.FourEntry"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 1, "optional", "repeated"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 2, "optional", "repeated"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 2, "string", "message"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 3, "repeated", "optional"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 4, "repeated", "optional"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 4, "message", "int64"),
newEnumsNotDeletedFailure("foo.v1.EnumTwo"),
newEnumsNotDeletedFailure("foo.v1.Six.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSix.Foo"),
newMessagesNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSixDelete"),
newEnumValuesNotDeletedFailure("foo.v1.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 2),
newEnumValuesSameNameFailure("foo.v1.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight.NestedNestedEight", "test"),
newServicesNotDeletedFailure("foo.v1.TwoAPI"),
newServiceMethodsNotDeletedFailure("foo.v1.OneAPI", "OneTwo"),
newMessagesNotDeletedFailure("foo.v1.OneTwoRequest"),
newMessagesNotDeletedFailure("foo.v1.OneTwoResponse"),
newMessageFieldsSameNameFailure("foo.v1.Nine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine.NestedNestedNine", 1, "one", "two"),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen.NestedNestedTen", "test", 3),
newServiceMethodsSameRequestTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneRequest", "foo.v1.OneOneRequest"),
newServiceMethodsSameResponseTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneResponse", "foo.v1.OneOneResponse"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneRequest"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneResponse"),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeTwo", true),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeThree", false),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFour", true),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFive", false),
newMessageFieldsSameOneofFailure("foo.v1.Eleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven.NestedNestedEleven", 1, "test"),
newMessagesNotDeletedFailure("foo.v1beta1.One.NestedOne.NestedNestedTwo"),
newMessagesNotDeletedFailure("foo.v1beta1.One.NestedTwo"),
newMessagesNotDeletedFailure("foo.v1beta1.Two"),
newMessageFieldsNotDeletedFailure("foo.v1beta1.Three", 2),
newMessageFieldsNotDeletedFailure("foo.v1beta1.Three.NestedThree", 2),
newMessageFieldsNotDeletedFailure("foo.v1beta1.Three.NestedThree.NestedNestedThree", 2),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 3, "foo.v1beta1.Four.NestedFour", "foo.v1beta1.One"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 3, "foo.v1beta1.Four.NestedFour.NestedNestedFour", "foo.v1beta1.One"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 4, "foo.v1beta1.EnumOne", "foo.v1beta1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 4, "foo.v1beta1.EnumOne", "foo.v1beta1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour", 4, "foo.v1beta1.EnumOne", "foo.v1beta1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Four.NestedFour.NestedNestedFour.SevenEntry", 1, "int64", "int32"),
newMessagesNotDeletedFailure("foo.v1beta1.Five.FourEntry"),
newMessageFieldsSameLabelFailure("foo.v1beta1.Five", 1, "optional", "repeated"),
newMessageFieldsSameLabelFailure("foo.v1beta1.Five", 2, "optional", "repeated"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Five", 2, "string", "message"),
newMessageFieldsSameLabelFailure("foo.v1beta1.Five", 3, "repeated", "optional"),
newMessageFieldsSameLabelFailure("foo.v1beta1.Five", 4, "repeated", "optional"),
newMessageFieldsSameTypeFailure("foo.v1beta1.Five", 4, "message", "int64"),
newEnumsNotDeletedFailure("foo.v1beta1.EnumTwo"),
newEnumsNotDeletedFailure("foo.v1beta1.Six.Foo"),
newEnumsNotDeletedFailure("foo.v1beta1.Six.NestedSix.Foo"),
newEnumsNotDeletedFailure("foo.v1beta1.Six.NestedSix.NestedNestedSix.Foo"),
newMessagesNotDeletedFailure("foo.v1beta1.Six.NestedSix.NestedNestedSixDelete"),
newEnumValuesNotDeletedFailure("foo.v1beta1.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1beta1.Seven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1beta1.Seven.NestedSeven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1beta1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 2),
newEnumValuesSameNameFailure("foo.v1beta1.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1beta1.Seven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1beta1.Seven.NestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1beta1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newMessageOneofsNotDeletedFailure("foo.v1beta1.Eight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1beta1.Eight.NestedEight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1beta1.Eight.NestedEight.NestedNestedEight", "test"),
newServicesNotDeletedFailure("foo.v1beta1.TwoAPI"),
newServiceMethodsNotDeletedFailure("foo.v1beta1.OneAPI", "OneTwo"),
newMessagesNotDeletedFailure("foo.v1beta1.OneTwoRequest"),
newMessagesNotDeletedFailure("foo.v1beta1.OneTwoResponse"),
newMessageFieldsSameNameFailure("foo.v1beta1.Nine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1beta1.Nine.NestedNine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1beta1.Nine.NestedNine.NestedNestedNine", 1, "one", "two"),
newMessageOneofsFieldsNotRemovedFailure("foo.v1beta1.Ten", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1beta1.Ten.NestedTen", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1beta1.Ten.NestedTen.NestedNestedTen", "test", 3),
newServiceMethodsSameRequestTypeFailure("foo.v1beta1.ThreeAPI", "ThreeOne", "foo.v1beta1.ThreeOneRequest", "foo.v1beta1.OneOneRequest"),
newServiceMethodsSameResponseTypeFailure("foo.v1beta1.ThreeAPI", "ThreeOne", "foo.v1beta1.ThreeOneResponse", "foo.v1beta1.OneOneResponse"),
newMessagesNotDeletedFailure("foo.v1beta1.ThreeOneRequest"),
newMessagesNotDeletedFailure("foo.v1beta1.ThreeOneResponse"),
newServiceMethodsSameClientStreamingFailure("foo.v1beta1.ThreeAPI", "ThreeTwo", true),
newServiceMethodsSameClientStreamingFailure("foo.v1beta1.ThreeAPI", "ThreeThree", false),
newServiceMethodsSameServerStreamingFailure("foo.v1beta1.ThreeAPI", "ThreeFour", true),
newServiceMethodsSameServerStreamingFailure("foo.v1beta1.ThreeAPI", "ThreeFive", false),
)
}
func TestRunOneAllowBetaDeps(t *testing.T) {
testRun(
t,
"one",
false,
true,
newPackagesNotDeletedFailure("bar.v1"),
newMessagesNotDeletedFailure("foo.v1.One.NestedOne.NestedNestedTwo"),
newMessagesNotDeletedFailure("foo.v1.One.NestedTwo"),
newMessagesNotDeletedFailure("foo.v1.Two"),
newMessageFieldsNotDeletedFailure("foo.v1.Three", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree", 2),
newMessageFieldsNotDeletedFailure("foo.v1.Three.NestedThree.NestedNestedThree", 2),
newMessageFieldsSameTypeFailure("foo.v1.Four", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 2, "string", "bytes"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 3, "foo.v1.Four.NestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 3, "foo.v1.Four.NestedFour.NestedNestedFour", "foo.v1.One"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 4, "foo.v1.EnumOne", "foo.v1.EnumThree"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 5, "enum", "double"),
newMessageFieldsSameTypeFailure("foo.v1.Four", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour", 6, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.SevenEntry", 1, "int64", "int32"),
newMessageFieldsSameTypeFailure("foo.v1.Four.NestedFour.NestedNestedFour.SevenEntry", 1, "int64", "int32"),
newMessagesNotDeletedFailure("foo.v1.Five.FourEntry"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 1, "optional", "repeated"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 2, "optional", "repeated"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 2, "string", "message"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 3, "repeated", "optional"),
newMessageFieldsSameLabelFailure("foo.v1.Five", 4, "repeated", "optional"),
newMessageFieldsSameTypeFailure("foo.v1.Five", 4, "message", "int64"),
newEnumsNotDeletedFailure("foo.v1.EnumTwo"),
newEnumsNotDeletedFailure("foo.v1.Six.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.Foo"),
newEnumsNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSix.Foo"),
newMessagesNotDeletedFailure("foo.v1.Six.NestedSix.NestedNestedSixDelete"),
newEnumValuesNotDeletedFailure("foo.v1.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.EnumSeven", 2),
newEnumValuesNotDeletedFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 2),
newEnumValuesSameNameFailure("foo.v1.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newEnumValuesSameNameFailure("foo.v1.Seven.NestedSeven.NestedNestedSeven.EnumSeven", 1, "ENUM_SEVEN_ONE", "ENUM_SEVEN_TWO"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight", "test"),
newMessageOneofsNotDeletedFailure("foo.v1.Eight.NestedEight.NestedNestedEight", "test"),
newServicesNotDeletedFailure("foo.v1.TwoAPI"),
newServiceMethodsNotDeletedFailure("foo.v1.OneAPI", "OneTwo"),
newMessagesNotDeletedFailure("foo.v1.OneTwoRequest"),
newMessagesNotDeletedFailure("foo.v1.OneTwoResponse"),
newMessageFieldsSameNameFailure("foo.v1.Nine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine", 1, "one", "two"),
newMessageFieldsSameNameFailure("foo.v1.Nine.NestedNine.NestedNestedNine", 1, "one", "two"),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen", "test", 3),
newMessageOneofsFieldsNotRemovedFailure("foo.v1.Ten.NestedTen.NestedNestedTen", "test", 3),
newServiceMethodsSameRequestTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneRequest", "foo.v1.OneOneRequest"),
newServiceMethodsSameResponseTypeFailure("foo.v1.ThreeAPI", "ThreeOne", "foo.v1.ThreeOneResponse", "foo.v1.OneOneResponse"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneRequest"),
newMessagesNotDeletedFailure("foo.v1.ThreeOneResponse"),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeTwo", true),
newServiceMethodsSameClientStreamingFailure("foo.v1.ThreeAPI", "ThreeThree", false),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFour", true),
newServiceMethodsSameServerStreamingFailure("foo.v1.ThreeAPI", "ThreeFive", false),
newMessageFieldsSameOneofFailure("foo.v1.Eleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven", 1, "test"),
newMessageFieldsSameOneofFailure("foo.v1.Eleven.NestedEleven.NestedNestedEleven", 1, "test"),
)
}
func testRun(t *testing.T, subDirPath string, includeBeta bool, allowBetaDeps bool, expectedFailures ...*text.Failure) {
fromPackageSet, toPackageSet, err := getPackageSets(subDirPath)
require.NoError(t, err)
runner := NewRunner()
config := settings.BreakConfig{
IncludeBeta: includeBeta,
AllowBetaDeps: allowBetaDeps,
}
failures, err := runner.Run(config, fromPackageSet, toPackageSet)
require.NoError(t, err)
for _, failure := range failures {
failure.LintID = ""
}
text.SortFailures(failures)
text.SortFailures(expectedFailures)
require.Equal(t, expectedFailures, failures)
}
func getPackageSets(subDirPath string) (*extract.PackageSet, *extract.PackageSet, error) {
fromFileDescriptorSets, err := ptesting.GetFileDescriptorSets(".", "testdata/"+subDirPath+"/from")
if err != nil {
return nil, nil, err
}
fromReflectPackageSet, err := reflect.NewPackageSet(fromFileDescriptorSets.Unwrap()...)
if err != nil {
return nil, nil, err
}
fromPackageSet, err := extract.NewPackageSet(fromReflectPackageSet)
if err != nil {
return nil, nil, err
}
toFileDescriptorSets, err := ptesting.GetFileDescriptorSets(".", "testdata/"+subDirPath+"/to")
if err != nil {
return nil, nil, err
}
toReflectPackageSet, err := reflect.NewPackageSet(toFileDescriptorSets.Unwrap()...)
if err != nil {
return nil, nil, err
}
toPackageSet, err := extract.NewPackageSet(toReflectPackageSet)
if err != nil {
return nil, nil, err
}
return fromPackageSet, toPackageSet, nil
}