Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Things outstanding to get to an A+ #8

Open
2 tasks done
sairafurqan opened this issue Apr 19, 2023 · 5 comments
Open
2 tasks done

Things outstanding to get to an A+ #8

sairafurqan opened this issue Apr 19, 2023 · 5 comments
Assignees

Comments

@sairafurqan
Copy link

sairafurqan commented Apr 19, 2023

Hello,

I was going through your project and you have not met all of the criteria for an A+. One of the things is really easy, and the other one is slightly more involved.

Here are the two things missing:

  • Plots are missing titles and some labels.
  • Upon closer look, we haven't seen evidence of the "complex method chaining" criteria and also there are no separate .Py files for any of the analysis book which is a requirement for A+ and A.

Complex method chaining

  • At least three advanced operations (e.g anonymous or lambda functions in assign or apply functions)
  • At least two method chains

At the moment, we're leaning towards downgrading your project to a B, but if you can fix these things before April 24th, we can award you your contracted grade of an A+ or A.

Of course, you are more than welcome to just accept the B, but please let us know either way what you decide.

Thanks,

Saira Furqan

@IfazYeanathChowdhury
Copy link
Contributor

We're going to fix it by the April 24th to achieve our contracted grade.

@IfazYeanathChowdhury
Copy link
Contributor

Just wanted to ask a quick question,
We're working on this issue right now, we'll be done implementing the changes by tomorrow. You mentioned needing this done by the 24th, do we have the usual 6pm deadline on the 24th or can we submit until midnight? Eitherways should be fine we should have the changes implemented by noon but I just wanted to make sure about how much time we have.

@IfazYeanathChowdhury
Copy link
Contributor

IfazYeanathChowdhury commented Apr 25, 2023

We finished addressing the feedback:

  1. For the plot titles and missing labels, my files (analysisIfaz) already had titles and labels. There were a few missing for Ananya's files we made sure we added those. I remember you mentioned having a legend for the titles, I tried adding the legends to some plots but the plots become very 'wordy' and it takes too much space. I believe having a legend included at the beginning of the analysis like we have (via markdown) is a more efficient way of conveying the information.
  2. Added more complex method chains (5+ lambda and other functions each for me and Ananya). Created a seperate .py file to import Ananya's functions.

Hopefully this is enough to atleast upgrade from B to A, if not A+.

@sairafurqan
Copy link
Author

@IfazYeanathChowdhury You created.py a file but not called that anywhere in your code.

@IfazYeanathChowdhury
Copy link
Contributor

IfazYeanathChowdhury commented Apr 25, 2023

I created the .py file for importing Ananya's functions and called it for her code, for some reason for my analysis files creating a seperate .py file to import functions was crashing my entire analysis so I avoided it. However, I added a-lot more apply functions and lambda to my code though to make method chaining more complex.
Screen Shot 2023-04-24 at 7 26 22 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants