Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify book build files #57

Open
pauldpickell opened this issue Sep 28, 2021 · 2 comments
Open

Minify book build files #57

pauldpickell opened this issue Sep 28, 2021 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@pauldpickell
Copy link
Contributor

Minify the resources (mostly JavaScript) in /docs/lib/ and other css and html files to enhance loading times.

@ect123
Copy link
Contributor

ect123 commented Sep 28, 2021

Since these files are in the docs/lib/ folder, will they be recreated each time new content is knitted for each chapter? If yes, then it would be good to include a minify step before each new version release. So before we merge develop to main.

@pauldpickell
Copy link
Contributor Author

pauldpickell commented Sep 28, 2021

Yes, I agree. Was just looking at /docs/raster-analysis-and-terrain-modelling.html, which is 74 MB and takes a while to load. Exploring solutions to speed up page loading generally, but in the case of this chapter specifically, it looks like the leaflet package in R encodes the json directly into the html rather than dynamically linking to the resource in /data. I will open a separate issue for this: #58

@pauldpickell pauldpickell added enhancement New feature or request documentation Improvements or additions to documentation labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants