New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The way to calculate the average in the BinarySearch may cause overflow. #9

Open

aimof opened this issue Apr 12, 2018 · 0 comments

aimof commented Apr 12, 2018

In BinarySearch, there are a code may cause overflow.

int((maxIndex + minIndex) / 2)

If (maxIndex + minIndex) is greater than max int, there occurs overflow and return wrong number.
We should calcurate like below.

int(minIndex + (maxIndex-minIndex)/2)

I'll make a PR.

aimof mentioned this issue

Fix #9: the way calculate average in BinarySearch #10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment