Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos powerswitch tooltip should say cmd not ctrl #350

Closed
8 tasks done
StefanoChiodino opened this issue Dec 22, 2018 · 1 comment
Closed
8 tasks done

macos powerswitch tooltip should say cmd not ctrl #350

StefanoChiodino opened this issue Dec 22, 2018 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@StefanoChiodino
Copy link

StefanoChiodino commented Dec 22, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

On macos the tooltip suggests using ctrl instead of cmd.

I've seen this mentioned in a couple of issues and PR in the main repo, where I don't have power to comment, but they are more than a year old and this is still an issue.

gorhill/uBlock#614
gorhill/uBlock#2338

A specific URL where the issue occurs

n/a

Steps to Reproduce

Click on the uBlock icon, hover on the powerswitch, read the second paragraph.

Expected behavior:

It should either only mention the cmd modifier on macos, or mention both.

I naively just changed the text, but can't submit a PR https://github.com/StefanoChiodino/uBlock/commit/f41a00a5962154fd1b80bcf51e58800c4f38aa49

Actual behavior:

Only ctrl is mentioned.

Your environment

  • MacOs, latest
  • uBlock Origin v1.17.4
  • Chrome Version 71.0.3578.98 (Official Build) (64-bit)

Thank you so much for working on this plugin!!!

@uBlock-user
Copy link
Contributor

uBlock-user commented Dec 22, 2018

Duplicate of gorhill/uBlock#614

I naively just changed the text, but can't submit a PR StefanoChiodino/uBlock@f41a00a

That's because that repository is closed to contributors only, if gorhill opens up for you to submit, then you will be able to.

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#614 Dec 22, 2018
@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants