Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tslint-react rule: jsx-no-multiline-js #524

Closed
JoshuaKGoldberg opened this issue May 9, 2020 · 3 comments
Closed

Missing tslint-react rule: jsx-no-multiline-js #524

JoshuaKGoldberg opened this issue May 9, 2020 · 3 comments
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: blocked We can't make progress on this issue until something else is resolved...

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 9, 2020 •
edited
Loading

Missing Converter

  • tslint-to-eslint-config version: 1.0.0-beta

  • typescript-eslint version: 2.31.0

TSLint Rule Name

jsx-no-multiline-js

Package Source

tslint-react: https://github.com/palantir/tslint-react (see #rules)

Equivalents for tslint-react rules generally live in eslint-plugin-react. If an ESLint rule equivalent doesn't yet exist, this tslint-to-eslint-config issue can be closed until that equivalent is created.
@JoshuaKGoldberg JoshuaKGoldberg added area: missing converter A rule converter should exist but doesn't yet. status: accepting prs Please, send in a PR to resolve this! ✨ labels May 9, 2020
@JoshuaKGoldberg JoshuaKGoldberg changed the title Missing tslint-react rule: ASDFjsx-no-multiline-js -m ### Missing tslint-react rule: jsx-no-multiline-js May 9, 2020
@JoshuaKGoldberg JoshuaKGoldberg added the good first issue Good for newcomers; welcome aboard! label May 9, 2020
@sonalisaxenacse12
Copy link

I will be working on this issue.

@sonalisaxenacse12
Copy link

sonalisaxenacse12 commented Jul 28, 2020 •
edited
Loading

@JoshuaKGoldberg, there is no equivalent rule for jsx-no-multiline-js in eslint-plugin-react , also there is an ongoing conversation on this.

We can close this issue for now.

@KingDarBoja KingDarBoja added status: blocked We can't make progress on this issue until something else is resolved... and removed status: accepting prs Please, send in a PR to resolve this! ✨ labels Aug 15, 2020
@KingDarBoja
Copy link
Collaborator

Will close this as the current rule is not implemented (yet) on eslint-plugin-react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: blocked We can't make progress on this issue until something else is resolved...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshuaKGoldberg @KingDarBoja @sonalisaxenacse12