Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Vercel #420

Open
armanbilge opened this issue Nov 11, 2023 · 2 comments · May be fixed by #492
Open

Support Vercel #420

armanbilge opened this issue Nov 11, 2023 · 2 comments · May be fixed by #492
Assignees
@Chingles2404
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@armanbilge
Copy link
Member

Documentation: https://vercel.com/docs/functions/serverless-functions/runtimes/node-js#advanced-node.js-usage

Vercel expects you to export a function whose signature is compatible with the argument to Node.js createServer method.

Fortunately there is already an implementation of such a function in http4s.

https://github.com/http4s/http4s/blob/ec939b1b354843d53293d4f9a9ac0e205fd4ec47/client-testkit/js/src/main/scala/org/http4s/client/testkit/scaffold/ServerScaffold.scala#L70-L72
@armanbilge armanbilge added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 11, 2023
@Chingles2404
Copy link
Contributor

Hi! I will be working on this :D

@armanbilge armanbilge linked a pull request Jul 9, 2024 that will close this issue
Created support for Vercel using Node.js runtime #492
Open
@armanbilge
Copy link
Member Author

Ching has been working on this in #492. Unfortunately it turns out that Vercel is not very flexible i.e. it lacks support for dynamic routing which is required to support http4s HttpApp, see #492 (comment) for additional details. So I think until Vercel supports that (or we can find some clever workaround) we will have to keep this integration on ice 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chingles2404 Chingles2404

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Typelevel Good First Issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Created support for Vercel using Node.js runtime Chingles2404/feral
2 participants
@armanbilge @Chingles2404