Skip to content

Add support for no_proxy / NO_PROXY #737

Open
@jongolden

Description

@jongolden

I am currently blocked from using this package due to the lack of support for NO_PROXY.

Here is my scenario:

  • I am working behind a corporate proxy and have HTTP_PROXY set as proxy.company-subdomain.com:8080
  • I am required to download mongodb from an internal mirror at https://mirror.company-subdomain.com/mongodb-linux[...]
  • Internal URLs should not be called through the proxy, so I have NO_PROXY set to .company-subdomain,localhost
  • Calling internal URLs through the proxy will always result in a BAD_GATEWAY error

I'd like to see support for NO_PROXY in this package. It looks like it would involve updating MongoBinaryDownload#download such that it resolves the proxy similar to request's getProxyFromUri, which returns null if the URL is included in the NO_PROXY variable.

Let me know if you are willing to support this and I would be happy to open a pull request.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions