Clean up old Rust gRPC compile code that used the 'grpc' crate (#166)

## What is the goal of this PR?

We cleaned up old Rust gRPC compile code that was using the `grpc`
crate, as we are now using the `tonic` crate instead.

## What are the changes implemented in this PR?

We successfully migrated `typedb-client-rust` from using the `grpc`
crate to the more actively-maintained `tonic` crate, and from the
`protobuf` crate (used by `grpc`) to the `prost` crate used by `tonic`.

So, we can now freely delete the old gRPC compiler code using the `grpc`
crate from `typedb-protocol`.

We've also integrated the Rust IDE sync tool into `typedb-protocol`,
which is needed to provide IntelliSense in our Rust sources.

Author: alexjpwalker

.gitignore

@@ -36,8 +36,13 @@ bazel-*
 # Compiled files #
 dist/
 out/
+target/
 *.class
 
+# Cargo files #
+Cargo.toml
+Cargo.lock
+
 # Mobile Tools for Java (J2ME) files #
 .mtj.tmp/
 

BUILD

@@ -59,6 +59,7 @@ exports_files(["README.md"])
 filegroup(
     name = "ci",
     data = [
+        "@vaticle_dependencies//ide/rust:sync",
         "@vaticle_dependencies//library/maven:update",
         "@vaticle_dependencies//tool/bazelrun:rbe",
         "@vaticle_dependencies//tool/unuseddeps:unused-deps",

WORKSPACE

@@ -76,10 +76,6 @@ java_grpc_compile()
 load("@stackb_rules_proto//node:deps.bzl", "node_grpc_compile")
 node_grpc_compile()
 
-load("@rules_rust//proto:repositories.bzl", "rust_proto_repositories")
-rust_proto_repositories()
-register_toolchains("//grpc/rust:proto_toolchain")
-
 # Load //tool/checkstyle
 load("@vaticle_dependencies//tool/checkstyle:deps.bzl", checkstyle_deps = "deps")
 checkstyle_deps()

dependencies/ide/BUILD

@@ -0,0 +1,25 @@
+#
+# Copyright (C) 2022 Vaticle
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+#
+
+load("@vaticle_dependencies//tool/checkstyle:rules.bzl", "checkstyle_test")
+
+checkstyle_test(
+    name = "checkstyle",
+    include = glob(["*"]),
+    license_type = "agpl-header",
+    size = "small",
+)

dependencies/ide/sync.sh

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+#
+# Copyright (C) 2022 Vaticle
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+#
+
+bazel run @vaticle_dependencies//ide/rust:sync

dependencies/vaticle/repositories.bzl

@@ -21,5 +21,5 @@ def vaticle_dependencies():
     git_repository(
         name = "vaticle_dependencies",
         remote = "https://github.com/vaticle/dependencies",
-        commit = "4464b506ca469f37d3b696fb2f1eda34061cdaa1", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
+        commit = "5be6d949ca1e04e4179ea6acb3432be713b9dfb8", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
     )

grpc/rust/BUILD

@@ -15,80 +15,12 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 
-load("@rules_rust//proto:proto.bzl", "rust_grpc_library")
-load("@rules_rust//proto:toolchain.bzl", "rust_proto_toolchain")
-load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library")
+load("@rules_rust//rust:defs.bzl", "rust_library")
 load("@rules_rust//cargo:cargo_build_script.bzl", "cargo_build_script")
 load("@vaticle_dependencies//tool/checkstyle:rules.bzl", "checkstyle_test")
 
-# TODO: once we clarify how we should compile the gRPC + Protobuf library, delete this target
-rust_binary(
-    name = "proto_compile",
-    srcs = ["main.rs"],
-    data = [
-        "//cluster:service-proto",
-        "//cluster:server-proto",
-        "//cluster:user-proto",
-        "//cluster:database-proto",
-        "//common:answer-proto",
-        "//common:concept-proto",
-        "//common:logic-proto",
-        "//common:options-proto",
-        "//common:query-proto",
-        "//common:session-proto",
-        "//common:transaction-proto",
-        "//core:database-proto",
-        "//core:service-proto",
-    ],
-    deps = [
-        "@vaticle_dependencies//library/crates:protoc_rust_grpc",
-    ],
-)
-
-rust_proto_toolchain(
-    name = "proto_toolchain_impl",
-    # Path to the protobuf compiler.
-    protoc = "@com_google_protobuf//:protoc",
-    # Protobuf compiler plugin to generate rust gRPC stubs.
-    grpc_plugin = "@vaticle_dependencies//library/crates:cargo_bin_protoc_gen_rust_grpc",
-    # Protobuf compiler plugin to generate rust protobuf stubs.
-    proto_plugin = "@vaticle_dependencies//library/crates:cargo_bin_protoc_gen_rust",
-)
-
-toolchain(
-    name = "proto_toolchain",
-    toolchain = ":proto_toolchain_impl",
-    toolchain_type = "@rules_rust//proto:toolchain_type",
-)
-
-rust_grpc_library(
-    name = "typedb_protocol_src",
-    deps = [
-        "//cluster:service-proto",
-        "//cluster:server-proto",
-        "//cluster:user-proto",
-        "//cluster:database-proto",
-        "//common:answer-proto",
-        "//common:concept-proto",
-        "//common:logic-proto",
-        "//common:options-proto",
-        "//common:query-proto",
-        "//common:session-proto",
-        "//common:transaction-proto",
-        "//core:database-proto",
-        "//core:service-proto",
-    ]
-)
-
-checkstyle_test(
-    name = "checkstyle",
-    include = glob(["*"]),
-    license_type = "agpl-header",
-    size = "small",
-)
-
 cargo_build_script(
-    name = "typedb-protocol-src",
+    name = "typedb_protocol_src",
     srcs = ["build.rs"],
     data = [
         "//cluster:service-proto",
@@ -110,20 +42,27 @@ cargo_build_script(
         "PROTOC": "$(execpath @com_google_protobuf//:protoc)"
     },
     deps = [
-        "@vaticle_dependencies//library/crates:tonic_build",
+        "@vaticle_dependencies//library/crates:tonic_build"
     ],
 )
 
 rust_library(
-    name = "typedb-protocol",
-    crate_name = "typedb_protocol_client",
-    srcs = [
-        "lib.rs"
-    ],
+    name = "typedb_protocol",
+    srcs = ["lib.rs"],
     deps = [
-        ":typedb-protocol-src",
+        ":typedb_protocol_src",
         "@vaticle_dependencies//library/crates:tonic",
         "@vaticle_dependencies//library/crates:prost",
     ],
+    tags = [
+        "crate-name=typedb-protocol",
+    ],
     visibility = ["//visibility:public"],
 )
+
+checkstyle_test(
+    name = "checkstyle",
+    include = glob(["*"]),
+    license_type = "agpl-header",
+    size = "small",
+)

grpc/rust/build.rs

@@ -17,6 +17,7 @@
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
     tonic_build::configure()
+        .build_client(true)
         .build_server(true)
         .compile(
             &[