From 6391f5caab87f4169ac3aab6c79008001addb6af Mon Sep 17 00:00:00 2001 From: "James C. Davis" Date: Wed, 23 Nov 2022 13:55:39 -0500 Subject: [PATCH] disable anti-classic eslint rules in ts-ember-preview-types --- test-packages/ts-ember-preview-types/.eslintrc.js | 2 ++ .../ts-ember-preview-types/app/components/bar/index.ts | 2 -- .../ts-ember-preview-types/app/components/ember-component.ts | 1 - test-packages/ts-ember-preview-types/app/components/foo.ts | 1 - test-packages/ts-ember-preview-types/app/components/qux.ts | 1 - .../app/components/test-cases/subclassing/parent.ts | 2 -- .../ts-ember-preview-types/app/components/wrapper-component.ts | 1 - .../ts-ember-preview-types/app/pods/components/baz/component.ts | 1 - 8 files changed, 2 insertions(+), 9 deletions(-) diff --git a/test-packages/ts-ember-preview-types/.eslintrc.js b/test-packages/ts-ember-preview-types/.eslintrc.js index 52ae66b08..95569dff4 100644 --- a/test-packages/ts-ember-preview-types/.eslintrc.js +++ b/test-packages/ts-ember-preview-types/.eslintrc.js @@ -22,6 +22,8 @@ module.exports = { }, rules: { '@typescript-eslint/no-empty-interface': 'off', + 'ember/no-classic-components': 'off', + 'ember/require-tagless-components': 'off', }, overrides: [ // node files diff --git a/test-packages/ts-ember-preview-types/app/components/bar/index.ts b/test-packages/ts-ember-preview-types/app/components/bar/index.ts index 4effa9eac..22cdee091 100644 --- a/test-packages/ts-ember-preview-types/app/components/bar/index.ts +++ b/test-packages/ts-ember-preview-types/app/components/bar/index.ts @@ -1,4 +1,3 @@ -// eslint-disable-next-line ember/no-classic-components import Component from '@ember/component'; export interface BarSignature { @@ -7,7 +6,6 @@ export interface BarSignature { }; } -// eslint-disable-next-line ember/require-tagless-components export default class Bar extends Component { name = 'BAR'; } diff --git a/test-packages/ts-ember-preview-types/app/components/ember-component.ts b/test-packages/ts-ember-preview-types/app/components/ember-component.ts index 6513e079a..c4e0a54a2 100644 --- a/test-packages/ts-ember-preview-types/app/components/ember-component.ts +++ b/test-packages/ts-ember-preview-types/app/components/ember-component.ts @@ -1,4 +1,3 @@ -/* eslint-disable ember/no-classic-components, ember/require-tagless-components */ import Component from '@ember/component'; export interface EmberComponentArgs { diff --git a/test-packages/ts-ember-preview-types/app/components/foo.ts b/test-packages/ts-ember-preview-types/app/components/foo.ts index b825f5f17..a78c00987 100644 --- a/test-packages/ts-ember-preview-types/app/components/foo.ts +++ b/test-packages/ts-ember-preview-types/app/components/foo.ts @@ -1,4 +1,3 @@ -/* eslint-disable ember/no-classic-components, ember/require-tagless-components */ import Component from '@ember/component'; import { ComponentLike } from '@glint/template'; diff --git a/test-packages/ts-ember-preview-types/app/components/qux.ts b/test-packages/ts-ember-preview-types/app/components/qux.ts index de5031bba..9994f9dcb 100644 --- a/test-packages/ts-ember-preview-types/app/components/qux.ts +++ b/test-packages/ts-ember-preview-types/app/components/qux.ts @@ -1,4 +1,3 @@ -/* eslint-disable ember/no-classic-components, ember/require-tagless-components */ import Component from '@ember/component'; export default class Qux extends Component { diff --git a/test-packages/ts-ember-preview-types/app/components/test-cases/subclassing/parent.ts b/test-packages/ts-ember-preview-types/app/components/test-cases/subclassing/parent.ts index 8459b0f09..25372e4ab 100644 --- a/test-packages/ts-ember-preview-types/app/components/test-cases/subclassing/parent.ts +++ b/test-packages/ts-ember-preview-types/app/components/test-cases/subclassing/parent.ts @@ -1,5 +1,3 @@ -// eslint-disable-next-line ember/no-classic-components import Component from '@ember/component'; -// eslint-disable-next-line ember/require-tagless-components export default class ParentClass extends Component {} diff --git a/test-packages/ts-ember-preview-types/app/components/wrapper-component.ts b/test-packages/ts-ember-preview-types/app/components/wrapper-component.ts index 0fe04e1fe..ad0b1d881 100644 --- a/test-packages/ts-ember-preview-types/app/components/wrapper-component.ts +++ b/test-packages/ts-ember-preview-types/app/components/wrapper-component.ts @@ -1,4 +1,3 @@ -/* eslint-disable ember/no-classic-components, ember/require-tagless-components */ import { ComponentLike, WithBoundArgs } from '@glint/template'; import Component from '@ember/component'; import EmberComponent from './ember-component'; diff --git a/test-packages/ts-ember-preview-types/app/pods/components/baz/component.ts b/test-packages/ts-ember-preview-types/app/pods/components/baz/component.ts index 6afbe6ab6..b53e85cab 100644 --- a/test-packages/ts-ember-preview-types/app/pods/components/baz/component.ts +++ b/test-packages/ts-ember-preview-types/app/pods/components/baz/component.ts @@ -1,4 +1,3 @@ -/* eslint-disable ember/no-classic-components, ember/require-tagless-components */ import Component from '@ember/component'; export interface BazSignature {