Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup with value #8

Open
DamodarSojka opened this issue Nov 29, 2016 · 3 comments
Open

Popup with value #8

DamodarSojka opened this issue Nov 29, 2016 · 3 comments

Comments

@DamodarSojka
Copy link

Hi

I have integrated sematic's popup (no javascript version, available since 2.2). Would you like a PR, or is it not compatible enough?

@tyleryasaka
Copy link
Owner

I'm not quite sure what you mean when you say you have integrated semantic's popup. Does the range slider currently not work with a popup?

If you want to submit a PR I'd be glad to look at it.

@DamodarSojka
Copy link
Author

It is easily possible to attach a popup to the whole slider, for me it is better to attach it to the moving dot (.thumb). It is possible to defined it outside and update in onChange:
$elem.find('.thumb').attr('data-tooltip', val);
But it is more elegant to include the popup directly inside the range.js.

My approach is very simplistic and only works with semantic 2.2+ when support for non-javascript popups was added. Btw javascript ones seems to be bugged when attached to .thumb, however I have not investigated much.

I hope I am clear enough this time.

@tyleryasaka
Copy link
Owner

@DamodarSojka feel free to make a pull request with your changes. If it breaks pre-2.2 versions I'll just publish your changes as a new release version and note the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants