-
Notifications
You must be signed in to change notification settings - Fork 23
Comparing changes
Open a pull request
base repository: twitter/bazel-multiversion
base: v0.1.0-M31
head repository: twitter/bazel-multiversion
compare: main
Commits on Jun 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 303ba6d - Browse repository at this point
Copy the full SHA 303ba6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66f990 - Browse repository at this point
Copy the full SHA f66f990View commit details
Commits on Sep 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 32c5180 - Browse repository at this point
Copy the full SHA 32c5180View commit details -
Merge pull request #97 from eed3si9n/wip/organization
Organization name
Configuration menu - View commit details
-
Copy full SHA for 1d2b895 - Browse repository at this point
Copy the full SHA 1d2b895View commit details
Commits on Sep 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7d9192a - Browse repository at this point
Copy the full SHA 7d9192aView commit details -
Merge pull request #98 from eed3si9n/wip/sbt-protobuf
sbt-protobuf 0.7.0
Configuration menu - View commit details
-
Copy full SHA for e14b3b4 - Browse repository at this point
Copy the full SHA e14b3b4View commit details
Commits on Sep 30, 2021
-
This adds `import-build` command as a new way of configuring dependencies using BUILDish DSL. This uses Starlark to evaluate `BUILD` files containing `jar_library(...)` calls.
Configuration menu - View commit details
-
Copy full SHA for e02d004 - Browse repository at this point
Copy the full SHA e02d004View commit details
Commits on Oct 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 48d6b7c - Browse repository at this point
Copy the full SHA 48d6b7cView commit details
Commits on Oct 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8f15ddd - Browse repository at this point
Copy the full SHA 8f15dddView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb43e9 - Browse repository at this point
Copy the full SHA dfb43e9View commit details -
Fix BUILDish on GraalVM native image
Problem ------- 0.1.0 can't import BUILDish. I originally tested only using JVM artifact, for native image requires a helper file to register reflection.
Configuration menu - View commit details
-
Copy full SHA for 95a06c5 - Browse repository at this point
Copy the full SHA 95a06c5View commit details -
Merge pull request #101 from eed3si9n/wip/native_image
Fix BUILDish on GraalVM native image
Configuration menu - View commit details
-
Copy full SHA for 9309fee - Browse repository at this point
Copy the full SHA 9309feeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5073564 - Browse repository at this point
Copy the full SHA 5073564View commit details
Commits on Dec 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1a23018 - Browse repository at this point
Copy the full SHA 1a23018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24c09d0 - Browse repository at this point
Copy the full SHA 24c09d0View commit details
Commits on Dec 8, 2021
-
This includes source JAR reference to scala_import.
Configuration menu - View commit details
-
Copy full SHA for cd0efc7 - Browse repository at this point
Copy the full SHA cd0efc7View commit details -
Merge pull request #103 from eed3si9n/wip/source_jars
Resolve source JARs
Configuration menu - View commit details
-
Copy full SHA for d57d9f9 - Browse repository at this point
Copy the full SHA d57d9f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a87865 - Browse repository at this point
Copy the full SHA 8a87865View commit details
Commits on Dec 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3f161de - Browse repository at this point
Copy the full SHA 3f161deView commit details -
Merge pull request #104 from eed3si9n/wip/sources_genrule
Wrap sources JARs in genrule
Configuration menu - View commit details
-
Copy full SHA for 4490f3a - Browse repository at this point
Copy the full SHA 4490f3aView commit details
Commits on Aug 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0421aef - Browse repository at this point
Copy the full SHA 0421aefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55bc406 - Browse repository at this point
Copy the full SHA 55bc406View commit details -
Merge pull request #106 from eed3si9n/wip/bazel5
Update example to Bazel 5.1.0
Configuration menu - View commit details
-
Copy full SHA for d299d93 - Browse repository at this point
Copy the full SHA d299d93View commit details
Commits on Aug 23, 2022
-
This implements rules_jvm_export, a Bazel rule to publish build artifacts to a Maven repository. Given that there's already [vaticle/bazel-distribution][1] rule, why make another one? The Maven-related rules in bazel-distribution has a good foundation so we are basing this rule off of it, but it does things that we don't need, and it doesn't do certain things we do want. Here are the main differences: - bazel-distribution uses Kotlin and Python to implement helper programs. This requires rules_kotlin to be introduced to `WORKSPACE`. rules_jvm_export only uses Python instead. - bazel-distribution creates an über JAR in the `assemble_maven(...)` rule, which includes classes coming from the dependencies. The jar_assembler seems to skip over `META-INF`, potentially losing info. rules_jvm_export by default uses the normal `build` artifacts. - rules_jvm_export just needs one target `jvm_export(...)` instead of `assemble_maven(...)` and `deploy_maven(...)`, in part because we're not creating assembly JAR by default. This is similar to rules_jvm_external's approach. - bazel-distribution uses a text file called `VERSION` to track the version number. rules_jvm_export introduces `jvm_export_version(...)` setting to track version numbers. These can be overridden from the command line without using `--define`. Here are the new features: - Support for bazel-multiversion 3rdparty targets. - `--netrc` option to use `.netrc` for authentication instead of environment variables. - rules_jvm_export supports file copying to local M2 repo. `--local` option can be passed to `bazel run` to publish to M2. [1]: https://github.com/vaticle/bazel-distribution
Configuration menu - View commit details
-
Copy full SHA for f839564 - Browse repository at this point
Copy the full SHA f839564View commit details -
Merge pull request #105 from eed3si9n/wip/jvm_export
Implement rules_jvm_export
Configuration menu - View commit details
-
Copy full SHA for 65fe4a6 - Browse repository at this point
Copy the full SHA 65fe4a6View commit details
Commits on Aug 24, 2022
-
Dependency version number for non-thirtparty nodes are not properly substituted. This fixes that.
Configuration menu - View commit details
-
Copy full SHA for 261aceb - Browse repository at this point
Copy the full SHA 261acebView commit details -
This lets you pass in repo URL or file path at the point of publishing as `--publish_to` parameter.
Configuration menu - View commit details
-
Copy full SHA for 79b5d84 - Browse repository at this point
Copy the full SHA 79b5d84View commit details -
Merge pull request #107 from eed3si9n/wip/dep_version
--publish_to support
Angela Guardia authoredAug 24, 2022 Configuration menu - View commit details
-
Copy full SHA for d79a807 - Browse repository at this point
Copy the full SHA d79a807View commit details
Commits on Aug 29, 2022
-
Include only direct deps in POM
Problem ------- POM contains dependencies to what should be transitive dependencies. The implementation uses aspect to walk the dependency graph, and currently it lists out transitive dependencies in POM as well. Solution -------- Remember the direct dependency in the aspect, and output only the direct dependencies in POM.
Configuration menu - View commit details
-
Copy full SHA for 9034edc - Browse repository at this point
Copy the full SHA 9034edcView commit details -
Ignore non-JVM targets along the dependency
Ignore non-JVM targets along the dependency graph while creating assembly JAR.
Configuration menu - View commit details
-
Copy full SHA for 1fac498 - Browse repository at this point
Copy the full SHA 1fac498View commit details -
Merge pull request #108 from eed3si9n/wip/follow-up
Include only direct deps in POM
Configuration menu - View commit details
-
Copy full SHA for ef1da0a - Browse repository at this point
Copy the full SHA ef1da0aView commit details
Commits on Sep 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 21eb1b0 - Browse repository at this point
Copy the full SHA 21eb1b0View commit details -
Merge pull request #109 from eed3si9n/wip/typo
Fix typo in POM generation
Configuration menu - View commit details
-
Copy full SHA for 0a2acb1 - Browse repository at this point
Copy the full SHA 0a2acb1View commit details
Commits on Sep 13, 2022
-
Problem ------- Publishing doesn't support custom classifiers. Solution -------- Add classifier publishing by letting the build user encode the information into the maven_coordinates tag. For example, to publish a JAR file as `abc` classifier, tag it as `maven_coordinates=com.twitter.dpb:io3:jar:abc:{pom_version}`. `jvm_export(...)` will pick that up to publish it with `-abc.jar` name.
Configuration menu - View commit details
-
Copy full SHA for 22aee51 - Browse repository at this point
Copy the full SHA 22aee51View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 524bff8 - Browse repository at this point
Copy the full SHA 524bff8View commit details -
Merge pull request #110 from eed3si9n/wip/classifier
classifier support
Configuration menu - View commit details
-
Copy full SHA for bb586d5 - Browse repository at this point
Copy the full SHA bb586d5View commit details
Commits on Oct 12, 2022
-
rules_scala Java library support
Problem ------- jvm_export assumes the target generates exactly one JAR file, but rules_scala actually creates two JAR files when there are Java files in the sources. Solution -------- As a workaround, assume that the target only contains Java sources, and pick the file whose name ends in `_java.jar`.
Configuration menu - View commit details
-
Copy full SHA for 29bf7a9 - Browse repository at this point
Copy the full SHA 29bf7a9View commit details -
Merge pull request #111 from eed3si9n/wip/java_publishing
rules_scala Java library support
Configuration menu - View commit details
-
Copy full SHA for 103b642 - Browse repository at this point
Copy the full SHA 103b642View commit details
Commits on Nov 2, 2022
-
Encode provided scope as neverlink
Problem ------- We want to emulate provided scope (compile scope in Pants) using neverlink, but the jvm_export rule is unaware of that. Solution -------- Track neverlink attribute in the aspect and send them into the Python script as if it's a classifier.
Configuration menu - View commit details
-
Copy full SHA for dcdf9d8 - Browse repository at this point
Copy the full SHA dcdf9d8View commit details
Commits on Nov 3, 2022
-
Update rules_jvm_export/jvm_export/support/pom_generator.py
Co-authored-by: Yi Cheng <wisechengyi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a25b671 - Browse repository at this point
Copy the full SHA a25b671View commit details -
Merge pull request #112 from eed3si9n/wip/neverlink
Encode provided scope as neverlink
Configuration menu - View commit details
-
Copy full SHA for e1a00e3 - Browse repository at this point
Copy the full SHA e1a00e3View commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bcae700 - Browse repository at this point
Copy the full SHA bcae700View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c994c9 - Browse repository at this point
Copy the full SHA 4c994c9View commit details -
Merge pull request #113 from eed3si9n/wip/bump
Update Coursier to 2.1.0-RC1
Configuration menu - View commit details
-
Copy full SHA for bf29039 - Browse repository at this point
Copy the full SHA bf29039View commit details
Commits on Nov 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3f37f60 - Browse repository at this point
Copy the full SHA 3f37f60View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d0f0d - Browse repository at this point
Copy the full SHA d1d0f0dView commit details
Commits on Feb 15, 2023
-
Add arg to specify input configuration in
export
Previously, the `export` command would always read its input from `3rdparty.yaml`. This commit adds a new parameter, `--input-path`, which configures where to read the 3rdparty configuration from. If the input file name ends with `.json`, then a JSON parser is used, instead of the default YAML parser.
Configuration menu - View commit details
-
Copy full SHA for f13aefa - Browse repository at this point
Copy the full SHA f13aefaView commit details
Commits on Feb 17, 2023
-
Merge pull request #115 from Duhemm/specify-input
Add arg to specify input configuration in `export`
Configuration menu - View commit details
-
Copy full SHA for 393dcdd - Browse repository at this point
Copy the full SHA 393dcddView commit details
Commits on Mar 6, 2023
-
Fix
jvm_export
with no sourcesPreviously, `jvm_export` rules with no sources (eg. a library that serves as an umbrella for several libraries) would fail during analysis with the following error: ``` ERROR: /Users/me/work/lib/BUILD:60:14: in jvm_export rule //lib:lib.publish: Traceback (most recent call last): File "(...)/jvm_export/jvm_export.bzl", line 43, column 37, in _jvm_export_impl source_jar = _source_jar(artifact) File "(...)/jvm_export/jvm_export.bzl", line 159, column 44, in _source_jar return target[JavaInfo].source_jars[0] Error: index out of range (index is 0, but sequence has 0 elements) ``` With this patch, the rule will no longer try to find a sources jar that doesn't exist.
Configuration menu - View commit details
-
Copy full SHA for 4433502 - Browse repository at this point
Copy the full SHA 4433502View commit details
Commits on Mar 10, 2023
-
Merge pull request #117 from Duhemm/export-no-sources
Fix `jvm_export` with no sources
Configuration menu - View commit details
-
Copy full SHA for 447c705 - Browse repository at this point
Copy the full SHA 447c705View commit details
There are no files selected for viewing