Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests: check both base & head for being a fork #104

Open
gr2m opened this issue Feb 17, 2020 · 0 comments
Open

Pull requests: check both base & head for being a fork #104

gr2m opened this issue Feb 17, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@gr2m
Copy link
Contributor

gr2m commented Feb 17, 2020

What happened?

See Mattlk13/p5.js#92. The linked pull request is unusual: Mattlk13/p5.js#92. The pull request head is the original repository, while base is the fork. It's a PR to keep a fork up-to-date.

What did you expect to happen?

There should not be an error.

What the problem might be

twitter-together currently only checks if head is a fork, but not base.

I assume that if we check for both, the problem should go away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant