Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability for towncrier's check to included staged files as part of its comparison against another branch #676

Closed
krpatter-intc opened this issue Dec 3, 2024 · 1 comment
Closed

add ability for towncrier's check to included staged files as part of its comparison against another branch #676

krpatter-intc opened this issue Dec 3, 2024 · 1 comment

Comments

@krpatter-intc
Copy link
Contributor

krpatter-intc commented Dec 3, 2024 •
edited
Loading

To enable using towncrier as a pre-commit hook (vs. a post-commit hook) it would be helpful if the towncrier check command included staged files as part of its comparison

This is a follow on to: #600 (comment)
@krpatter-intc krpatter-intc mentioned this issue Dec 4, 2024
Merged
7 tasks
@adiroiban
Copy link
Member

Fixed by #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adiroiban @krpatter-intc