Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leaks with Fix #429

Open
lamdacore opened this issue Aug 7, 2023 · 0 comments
Open

Memory Leaks with Fix #429

lamdacore opened this issue Aug 7, 2023 · 0 comments
Labels
bug Something isn't working needs exploration Needs more work done to confirm if it's valid

Comments

@lamdacore
Copy link

Hi,

during watching subathon VOD, what about 20 Hours or even 40 Hours go, I encounter some memory leaks. One time it was so massive, that the complete phone got very slow and later on it killed the whole twire app.

I decided to see if I can find those memory leaks with Android Profiler and it seems i found them. I even was capable to fix them.

Here are my fixes: (.diff files)
MemoryLeakFix.zip

I hope those fixes can be flow in, in the next official version.

Here some detail:
one fix is that there was used a weak reference of the an activity in a background task, but the activity was given in the doBackground function and that still causes a memory leak .. it should be given in the constructor of the background task class.

the other fixes are related to static functions what got excluded by garbage collection, Especially by static Fragment classes.

@lamdacore lamdacore added bug Something isn't working needs exploration Needs more work done to confirm if it's valid labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs exploration Needs more work done to confirm if it's valid
Projects
None yet
Development

No branches or pull requests

1 participant