Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number in two places #20

Open
dentarg opened this issue Feb 23, 2016 · 1 comment
Open

Version number in two places #20

dentarg opened this issue Feb 23, 2016 · 1 comment
Labels
small

Comments

@dentarg
Copy link
Contributor

dentarg commented Feb 23, 2016 •
edited
Loading

We have it in setup.py and twingly_search/__init__.py (only two digits here, so maybe we are well aware of it?)

Perhaps in setup.py we can use the version from __init__.py like html5lib does.
@dentarg dentarg added the small label Feb 24, 2016
roback added a commit that referenced this issue Mar 3, 2016
@roback
Update release instructions
7384c0f 
THe version number is in two places, but we have #20 for that.
@roback
Copy link
Member

roback commented Mar 3, 2016

We have it in setup.py and twingly_search/init.py (only two digits here, so maybe we are well aware of it?)

I don't think it was intentional to leave out the last version number here. Its only used in the user agent string. The other clients includes the patch version so I changed it when bumping the version in 5d6d8c5.

roback added a commit that referenced this issue Apr 18, 2019
@roback
Only define version number in one place
4803437 
close #20
@roback roback mentioned this issue Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only define version number in one place twingly/twingly-search-api-python
2 participants
@dentarg @roback