You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The Voice SDK is limited to selecting input devices that have a device id. While this works for most cases it would be great if developers had the flexibility to provide a stream as an input instead of a device. In the case of our application we mix the user's mic input with an additional audio source to provide additional context about the call session.
Describe the solution you'd like
It would be ideal if AudioHelper.setInputDevice could accept a device id or a MediaStream. Alternatively add an additional method AudioHelper.setInputStream. It appears the the device id is only used to build constraints to getUserMedia. The device does not appear to be used as well outside of automated testing from what I can tell.
I have tested this by forking the library and adding a method device.audio.setInputStream based on the implementation of AudioHelper._setInputDevice. I confirmed that it works as expected. Would be open to contributing this back to Twilio if a maintainer can provide a recommendation to their preferred implementation path.
Describe alternatives you've considered
I have tried to consider other solutions to achieve my desired outcome and thus far this appears to be the only path forward.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Hi Adam,
Thanks for the PR. I did leave some comments a few months ago, but haven't heard back in a while. Please let me know if you're still interested in getting this merged!
Is your feature request related to a problem? Please describe.
The Voice SDK is limited to selecting input devices that have a device id. While this works for most cases it would be great if developers had the flexibility to provide a stream as an input instead of a device. In the case of our application we mix the user's mic input with an additional audio source to provide additional context about the call session.
Describe the solution you'd like
It would be ideal if
AudioHelper.setInputDevice
could accept a device id or a MediaStream. Alternatively add an additional methodAudioHelper.setInputStream
. It appears the the device id is only used to build constraints togetUserMedia
. The device does not appear to be used as well outside of automated testing from what I can tell.I have tested this by forking the library and adding a method
device.audio.setInputStream
based on the implementation ofAudioHelper._setInputDevice
. I confirmed that it works as expected. Would be open to contributing this back to Twilio if a maintainer can provide a recommendation to their preferred implementation path.Describe alternatives you've considered
I have tried to consider other solutions to achieve my desired outcome and thus far this appears to be the only path forward.
Additional context
N/A
The text was updated successfully, but these errors were encountered: