Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssinliner-extra] CssToInlineStyles implicit nullable types deprecations (PHP 8.4) #4056

Closed
smnandre opened this issue Apr 28, 2024 · 4 comments

Comments

@smnandre
Copy link
Contributor

CssToInlineStyles (used in twig-extra) package triggers deprecations on PHP 8.4

  1x: TijsVerkoyen\CssToInlineStyles\Css\Property\Processor::convertToObject(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead
    1x in IntegrationTest::testIntegration from Twig\Extra\CssInliner\Tests

  1x: TijsVerkoyen\CssToInlineStyles\Css\Property\Processor::convertArrayToObjects(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead
    1x in IntegrationTest::testIntegration from Twig\Extra\CssInliner\Tests

  1x: TijsVerkoyen\CssToInlineStyles\Css\Property\Property::__construct(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead
    1x in IntegrationTest::testIntegration from Twig\Extra\CssInliner\Tests

I would have created a PR on the package repo, but as the package is compatible with PHP 5.5 i'm not sure what to do ...

AFAIK there is no simple solution for librairies supporting PHP < 7.1 (where nullable argument was introduced)

How is it possible to deal with such situation ?

@fabpot
Copy link
Contributor

fabpot commented Apr 29, 2024

At this point, I would recommend that the project drops such old versions of PHP.

@smnandre
Copy link
Contributor Author

I've just realised @stof is one of the maintainer (or can merge PR at least - not sure) of CssToInlineStyles. What do you think ? Do we have other alternatives ?

@xabbuh
Copy link
Contributor

xabbuh commented May 2, 2024

see tijsverkoyen/CssToInlineStyles#247

@fabpot
Copy link
Contributor

fabpot commented May 4, 2024

Closing here then.

@fabpot fabpot closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants