Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Warnings if we generate methods with same name as existing methods #27

Open
twiglet opened this issue Jul 19, 2011 · 0 comments
Open

Comments

@twiglet
Copy link
Owner

twiglet commented Jul 19, 2011

I was thinking of a case like this:

public class RenameTest {

    public string AMethod(object x) {
        return "AMethod has arg " + x.ToString();
    }

    public string aMethod(string s) {
        return "aMethod has string arg \"" + s + "\"";
    }

    public static void RNMain(string arg) {
        RenameTest rnObj = new RenameTest();
        Console.Out.WriteLine(rnObj.AMethod(arg));   // *******
    }   

}

After renaming then the starred line will call a different method because of the more specific overload.

As you say this can happen already with properties and setXXXXX methods. We will look into adding warnings if we detect this might happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant