Skip to content

Compatibility with aeson 2.x #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
infinisil opened this issue Sep 16, 2021 · 6 comments
Closed

Compatibility with aeson 2.x #22

infinisil opened this issue Sep 16, 2021 · 6 comments

Comments

@infinisil
Copy link
Member

We're using aeson to decode potentially malicious JSON, which has a known vulnerability that could allow a DoS attack: https://cs-syd.eu/posts/2021-09-11-json-vulnerability. We should look whether this can be exploited in this library, and fix it if so. Issue to track: haskell/aeson#864

@lykahb
Copy link
Contributor

lykahb commented Sep 16, 2021

I wouldn't worry much about mitigating DoS just within the haskell-fido2 library. The chances are that a server that uses haskell-fido2 relies on aeson too. Fixing aeson would be the best for the Haskell ecosystem.

@infinisil
Copy link
Member Author

Sounds reasonable, so let's not act on it, but keep it in mind

@arianvp
Copy link
Contributor

arianvp commented Oct 19, 2021

This is fixed in the new aeson release

@infinisil
Copy link
Member Author

There's some compilation performance problem with deriving-aeson (which we're using) when using aeson 2.x, see fumieval/deriving-aeson#16. If this isn't fixed soon we'll have to not rely on deriving-aeson so we can update aeson.

@infinisil infinisil changed the title Make sure we can't be DoS'd Compatibility with aeson 2.x Jan 14, 2022
@infinisil
Copy link
Member Author

This is being worked on by @ErinvanderVeen in https://github.com/tweag/webauthn/tree/aeson-2. We will make sure to have compatibility with both aeson 1.x and 2.x

@infinisil
Copy link
Member Author

This has been done with #115, we support both Aeson 1.x and 2.x now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants