Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cheatsheet examples horizontal scrolling #40799

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 7, 2024

Description

This PR fixes the horizontal scrolling happening on small devices in both Cheatsheet examples.

This was due to the dropdown section: if you remove it, there's no more horizontal scrolling on mobile for both Firefox and Chrome. In this dropdowns section, it comes from two places where there was a w-100 div:

<div class="btn-group w-100 align-items-center justify-content-between flex-wrap">
Screenshot 2024-09-07 at 09 13 43

The idea here is to remove the end margin to avoid that extra space that causes the horizontal scrolling.

However, this fix doesn't work under 273px wide screens as there's after an issue with the Tables section.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40798

@diafestivo
Copy link

Thank you for the quick response and swift solution! It works!

@julien-deramond julien-deramond marked this pull request as ready for review September 8, 2024 12:41
@julien-deramond julien-deramond requested a review from a team September 8, 2024 12:41
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. 273px seems to be a very small screen and I don't think we should handle this case tbh.

@julien-deramond julien-deramond merged commit fee9dc2 into main Oct 8, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-cheatsheet-example-horizontal-scrolling branch October 8, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cheatsheet horizontal scrolling
3 participants