Fix/groups table migration (#853)

* fix: rewrite create roles migration

Simplified it and added a check to only insert if there are no roles

* fix: insert default roles in seed file

Seeds will empty the database so this is necessary to prevent
foreign key errors when inserting into group_members

* fix: add python dependency

some npm packages will need python

* refactor: use env variable for db port

Author: brianmarete

docker-compose.yml

@@ -9,7 +9,7 @@ services:
       - ./data/postgres/:/var/lib/postgresql/data/
     env_file: .env
     ports:
-      - '5432'
+      - "${POSTGRES_PORT}:${POSTGRES_PORT}"
     networks:
       - wikonnect
     healthcheck:

server/Dockerfile

@@ -1,4 +1,5 @@
 FROM node:fermium-alpine3.14
+RUN apk add g++ make py3-pip
 
 ARG NODE_ENV='production'
 ARG SERVER_PORT=3000

server/db/migrations/20211124112429_create_roles.js

@@ -1,56 +1,34 @@
-
-exports.up = async function(knex) {
-  await knex.schema.alterTable('group_members', (table) => {
-    table.dropPrimary();
-    table.dropForeign('group_id');
-    table
-        .foreign('group_id')
-        .references('groups.id')
-        .onDelete('CASCADE')
-        .onUpdate('CASCADE');
-    table.text('id').primary().notNullable().defaultTo(knex.raw('next_id()'));
-  });
-
-  return knex('groups').insert([
-    { 
-      id: 'groupAdmin', 
-      name: 'admin', 
-      slug: 'role-admin', 
-      created_at: new Date().toISOString(), 
-      updated_at: new Date().toISOString()
-    },
-    { 
-      id: 'groupModerator', 
-      name: 'moderator', 
-      slug: 'role-moderator', 
-      created_at: new Date().toISOString(), 
-      updated_at: new Date().toISOString()
-    },
-    { 
-      id: 'groupBasic', 
-      name: 'basic', 
-      slug: 'role-basic', 
-      created_at: new Date().toISOString(), 
-      updated_at: new Date().toISOString() 
-    }
-  ]);
+exports.up = async function (knex) {
+  return await knex("groups")
+    .select()
+    .whereIn("name", ["admin", "moderator", "basic"])
+    .then((rows) => {
+      if (rows.length === 0) {
+        return knex("groups").insert([
+          {
+            id: "groupAdmin",
+            name: "admin",
+            slug: "role-admin",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+          {
+            id: "groupModerator",
+            name: "moderator",
+            slug: "role-moderator",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+          {
+            id: "groupBasic",
+            name: "basic",
+            slug: "role-basic",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+        ]);
+      }
+    });
 };
 
-exports.down = async function(knex) {
-  await knex.schema.alterTable('group_members', (table) => {
-    table.setNullable('group_id');
-  });
-
-  await knex('groups').whereIn('name', [
-    'admin',
-    'moderator',
-    'basic',
-  ]).del();
-
-  return knex.schema.alterTable('group_members', (table) => {
-    table.dropPrimary();
-    table.dropColumn('id');
-    table.dropNullable('group_id');
-    table.primary(['user_id', 'group_id']);
-  });
-};
+exports.down = async function (knex) {};

server/db/seeds/dev/20_group_members.js

@@ -1,30 +1,79 @@
-const { faker, seed_number } = require('../_seeds');
+const { faker, seed_number } = require("../_seeds");
 
 exports.seed = async (knex) => {
   // Deletes ALL existing entries
-  await knex('group_members').del();
 
-  const userIds = await knex('users').whereNotIn('id', ['user1', 'user2', 'user3']).pluck('id');
-  const groupIds = await knex('groups').pluck('id');
+  await knex("groups")
+    .select()
+    .whereIn("name", ["admin", "moderator", "basic"])
+    .then((rows) => {
+      if (rows.length === 0) {
+        return knex("groups").insert([
+          {
+            id: "groupAdmin",
+            name: "admin",
+            slug: "role-admin",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+          {
+            id: "groupModerator",
+            name: "moderator",
+            slug: "role-moderator",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+          {
+            id: "groupBasic",
+            name: "basic",
+            slug: "role-basic",
+            created_at: new Date().toISOString(),
+            updated_at: new Date().toISOString(),
+          },
+        ]);
+      }
+    });
+
+  const groupIds = await knex("groups").pluck("id");
+  console.log("===========================================", groupIds);
+  await knex("group_members").truncate();
+
+  const userIds = await knex("users")
+    .whereNotIn("id", ["user1", "user2", "user3"])
+    .pluck("id");
 
   let groupMembers = [
-    { user_id: 'user1', group_id: 'groupAdmin', created_at: faker.date.past(), updated_at: faker.date.recent() },
-    { user_id: 'user2', group_id: 'groupModerator', created_at: faker.date.past(), updated_at: faker.date.recent() },
-    { user_id: 'user3', group_id: 'groupBasic', created_at: faker.date.past(), updated_at: faker.date.recent() },
+    {
+      user_id: "user1",
+      group_id: "groupAdmin",
+      created_at: faker.date.past(),
+      updated_at: faker.date.recent(),
+    },
+    {
+      user_id: "user2",
+      group_id: "groupModerator",
+      created_at: faker.date.past(),
+      updated_at: faker.date.recent(),
+    },
+    {
+      user_id: "user3",
+      group_id: "groupBasic",
+      created_at: faker.date.past(),
+      updated_at: faker.date.recent(),
+    },
   ];
 
-  const maxSeeds = groupMembers.length > seed_number ? 0 : seed_number - groupMembers.length;
+  const maxSeeds =
+    groupMembers.length > seed_number ? 0 : seed_number - groupMembers.length;
 
   for (let i = 0; i < maxSeeds; i++) {
     groupMembers.push({
       user_id: userIds[i],
       group_id: faker.random.arrayElement(groupIds),
       created_at: faker.date.past(),
-      updated_at: faker.date.recent()
+      updated_at: faker.date.recent(),
     });
   }
 
-
-  return knex('group_members').insert(groupMembers);
-
+  return knex("group_members").insert(groupMembers);
 };