Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to kinetic #94

Open
rdelgadov opened this issue Nov 16, 2017 · 6 comments
Open

Port to kinetic #94

rdelgadov opened this issue Nov 16, 2017 · 6 comments

Comments

@rdelgadov
Copy link

Hi,

I use the solution of #78 writen by @SpaceMingebag and the package work well in ROS Kinetic in simulator.

What I need to do to make the contribution?

@lesire
Copy link
Member

lesire commented Nov 16, 2017

Hi,
Contributions are very welcome!! :)
Fork the repo, modify it, and create a pull request to merge it into the main repo.
Thanks !

@rdelgadov
Copy link
Author

Can you create the kinetic branch pls?

@cyberphantom
Copy link

Hi just change the RosThread.h to this

#ifndef Q_MOC_RUN
#include "cvd/thread.h"
#include "tum_ardrone/filter_state.h"
#include "std_msgs/String.h"
#include "geometry_msgs/Twist.h"
#include "ardrone_autonomy/Navdata.h"
#include "ros/ros.h"
#include "sensor_msgs/Joy.h"
#include "std_srvs/Empty.h"
#include "std_msgs/Empty.h"
#endif

as mentioned in #78

@abaddriver
Copy link

hi,
I'm also trying to make the tum_ardrone work on kinetic.
for some reason, i cant get it to compile the project:
i'm following the instructions under these instructions:
"
cd catkin_ws/src
git clone https://github.com/tum-vision/tum_ardrone.git -b hydro-devel
cd ..
rosdep install tum_ardrone
catkin_make
"

the outcome is really fast and it doesn't seem to even try to compile the package.
what am i missing?

this is the output on my computer:

(cv) yoni@yoni:/catkin_ws$ rosdep install tum_ardrone
#All required rosdeps installed successfully
(cv) yoni@yoni:
/catkin_ws$ catkin_make
Base path: /home/yoni/catkin_ws
Source space: /home/yoni/catkin_ws/src
Build space: /home/yoni/catkin_ws/build
Devel space: /home/yoni/catkin_ws/devel
Install space: /home/yoni/catkin_ws/install

Running command: "make cmake_check_build_system" in "/home/yoni/catkin_ws/build"

Running command: "make -j4 -l4" in "/home/yoni/catkin_ws/build"

[ 0%] Built target std_msgs_generate_messages_nodejs
[ 0%] Built target std_msgs_generate_messages_eus
[ 0%] Built target std_msgs_generate_messages_py
[ 0%] Built target std_msgs_generate_messages_lisp
[ 0%] Built target std_msgs_generate_messages_cpp
[ 0%] Built target _of_avihay_ronly_pkg_generate_messages_check_deps_cordinate
[ 28%] Built target of_avihay_ronly_pkg_generate_messages_lisp
[ 28%] Built target of_avihay_ronly_pkg_generate_messages_nodejs
[ 57%] Built target of_avihay_ronly_pkg_generate_messages_py
[ 85%] Built target of_avihay_ronly_pkg_generate_messages_eus
[100%] Built target of_avihay_ronly_pkg_generate_messages_cpp
[100%] Built target of_avihay_ronly_pkg_generate_messages
(cv) yoni@yoni:~/catkin_ws$

@rdelgadov
Copy link
Author

Hi,

Try clonning this repository in the kinetic-devel branch and do the same steps without the "-b hydro-devel"

@abaddriver
Copy link

@rdelgadov i tried it, and i still get the same outcome..
it's like it doesn't know about the existence of the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants