Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: copy without depdendency #69

Closed
rafzi opened this issue Jul 29, 2021 · 5 comments
Closed

cmake: copy without depdendency #69

rafzi opened this issue Jul 29, 2021 · 5 comments

Comments

@rafzi
Copy link
Member

rafzi commented Jul 29, 2021

In the main cmake, there is a block of code that copies includes into the build folder for an in-tree build of etiss.

https://github.com/tum-ei-eda/etiss/blob/master/CMakeLists.txt#L296

This is missing some dependency to the original includes. If they are changed, the change will not be reflected in the build folder, unless cmake is run manually.

To fix this we'd probably want to add custom commands: https://stackoverflow.com/questions/8434055/cmake-copy-if-original-file-changed

@uzleosharif

@uzleosharif
Copy link
Contributor

hi thanks for mentioning the issue. i have a look over the weekend to get to know the issue and possibly try your suggested fix to resolve this issue

@uzleosharif
Copy link
Contributor

hi @rafzi i dont remember why we needed to copy include files in the first place..in the latest master branch commit, i am able to use etiss in build-tree even if i dont copy the include files.....so we might as well remove the lines 298-301

however i am not sure about this issue then if we dont have dependency on /include at all. Could you elaborate with a test example further explaining this issue

@rafzi
Copy link
Member Author

rafzi commented Sep 2, 2021

If the copy is not required, we should remove it and that would resolve this issue.

I'm not sure if there was an actual problem caused by this. I was just noticing that there were these include files that could become out-of-sync with the original ones.

@uzleosharif
Copy link
Contributor

cool then i remove it and update the master..thanks a lot

@uzleosharif
Copy link
Contributor

fixed in commit 4c36313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants