Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Broken after removing 'examples/' 8f2fb89 #148

Closed
JoGei opened this issue Jun 6, 2024 · 5 comments · Fixed by #149
Closed

CI: Broken after removing 'examples/' 8f2fb89 #148

JoGei opened this issue Jun 6, 2024 · 5 comments · Fixed by #149

Comments

@JoGei
Copy link
Member

JoGei commented Jun 6, 2024

After commit 8f2fb89 removed the examples/ CI was not updated and fails.

@jokap11
Copy link
Contributor

jokap11 commented Jun 9, 2024

Do you think this is a suitable solution? 0b8ad8a
Removing all example parts?
Or should the CI file load the submodule?

@PhilippvK
Copy link
Member

PhilippvK commented Jun 9, 2024

The etiss riscv tests moved to https://github.com/tum-ei-eda/etiss_riscv_examples.

(@wysiwyng)

To fix the CI in the etiss repo we could:

  1. Drop the CI jobs all together (not recommended)
  2. Build new CI jobs in this repository based on etiss_riscv_examples.
    a) Using a submodule
    b) Using checkout action in CI
  3. Add CI to etiss_riscv_examples repository and trigger it from the etiss repo (if feasible)

@JoGei
Copy link
Member Author

JoGei commented Jun 10, 2024

Do you think this is a suitable solution? 0b8ad8a Removing all example parts? Or should the CI file load the submodule?

No, not really. I think the examples and the CI tests were quite helpful as a form of "sanity tests". So I would try to keep them.

@JoGei
Copy link
Member Author

JoGei commented Jun 10, 2024

The etiss riscv tests moved to https://github.com/tum-ei-eda/etiss_riscv_examples.

(@wysiwyng)

To fix the CI in the etiss repo we could:

1. Drop the CI jobs all together (not recommended)

2. Build new CI jobs in this repository based on `etiss_riscv_examples`.
   a) Using a submodule
   b) Using checkout action in CI

3. Add CI to `etiss_riscv_examples` repository and trigger it from the `etiss` repo (if feasible)

2.b) sounds best IMO

@wysiwyng
Copy link
Contributor

wysiwyng commented Jun 11, 2024

I also think 2.b) is the best option, I will rewrite the ci file. We could also add https://github.com/tum-ei-eda/etiss_riscv_tests here to have actual functional tests. These should then only report the status, not fail the CI when tests don't pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants