Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deleting tasks in the list below when adding a description #106

Open
TonyAtlas opened this issue Jan 4, 2025 · 9 comments
Open

[BUG] Deleting tasks in the list below when adding a description #106

TonyAtlas opened this issue Jan 4, 2025 · 9 comments
Labels
bug Something isn't working

Comments

@TonyAtlas
Copy link

TonyAtlas commented Jan 4, 2025

I have my tasks listed in one file. When I add a description to a task through the plugin, the entire list of tasks below is removed. If I do it not through the plugin, but just edit a note, the description is displayed in the plugin and the tasks below are not deleted.

When adding a tag through the plugin, the same thing happens.

I try to use the plugin together with the Tasks plugin. Tasks plugin is enabled in the settings.

@tu2-atmanand
Copy link
Owner

Hii @TonyAtlas !

Thank you so much for reporting the issue.

I actually tried creating a note and adding multiple tasks, one below the other. I haven't faced the issue you mentioned. But I might have been used a different format.

Can you please share a format of the note which you are editing. Like only replace the content with some dummy data and keep the rest of the empty lines, white spaces etc. exactly same as the original note.

Through this issue, we might be able to solve even the rarest bugs 💪

@tu2-atmanand tu2-atmanand added the bug Something isn't working label Jan 4, 2025
@tu2-atmanand tu2-atmanand moved this to Important Backlog in Task Board Dev Jan 4, 2025
@TonyAtlas
Copy link
Author

Hii @TonyAtlas !

Thank you so much for reporting the issue.

I actually tried creating a note and adding multiple tasks, one below the other. I haven't faced the issue you mentioned. But I might have been used a different format.

Can you please share a format of the note which you are editing. Like only replace the content with some dummy data and keep the rest of the empty lines, white spaces etc. exactly same as the original note.

Through this issue, we might be able to solve even the rarest bugs 💪

Hello! Thank you for your quick reply.

Yes, of course. Here's an example of the items in the list (I'll keep the original tag names just in case):

- [ ] #✔️дел Task-1 🔺 📅 2025-01-04
- [ ] #✔️дел Task-2 🔺 🔁 every week on Thursday 📅 2025-01-09
- [ ] #✔️дел Task-3 🔺 📅 2025-01-09
- [ ] #✔️дел Task-4 🔺 📅 2025-01-01

@tu2-atmanand
Copy link
Owner

tu2-atmanand commented Jan 8, 2025

Hii @TonyAtlas !

Thank again for reporting this issue. I have confirmed it's a bug after testing. Somehow, it went unnoticed.

The bug has been almost solved, and the fix will be provided in the next release, v1.3.0.

I have solved the bug and now after updating through the Edit Task Pop-up, above data will look like this :

- [ ] #✔️дел Task-1 🔺 📅 2025-01-04 |🔺 📅 2025-01-04 #✔️дел #Testing
	- [ ] Adding sub-task for testing.
	Adding a new line in description for testing.
- [ ] #✔️дел Task-2 🔺 🔁 every week on Thursday 📅 2025-01-09
- [ ] #✔️дел Task-3 🔺 📅 2025-01-09
- [ ] #✔️дел Task-4 🔺 📅 2025-01-01

Suggestion : You might have noticed, when i updated the Task-1, the metadata is duplicated after the pipe symbol. So, if you like, you can make use of this pipe symbol feature to keep the properties separate from the task itself.
At least until the following new feature will be implemented : #110

@tu2-atmanand tu2-atmanand moved this from Important Backlog to In progress in Task Board Dev Jan 8, 2025
tu2-atmanand added a commit that referenced this issue Jan 8, 2025
@tu2-atmanand
Copy link
Owner

tu2-atmanand commented Jan 8, 2025

Actually, I have planned few other things for the next release v1.3.0, which seen from the roadmap. These things might gonna take some time to achieve, so it will be good idea to publish this bug fix before that. Hence, I have released a new version : Task Board v1.2.1 release

If you have installed this plugin using BRAT, the plugin should auto update. Or you can update it using the BRAT setting, by enabling the auto update setting option.

Let me know if everything is working fine. You can close this issue, if the original bug has been solved.
Feel free to open new issues, if you have any other suggestion, bug report or feature request.

@tu2-atmanand tu2-atmanand moved this from In progress to Ready to Review in Task Board Dev Jan 8, 2025
@TonyAtlas
Copy link
Author

TonyAtlas commented Jan 8, 2025

Thank you for responding so quickly and fixing the problem! 🙏

Indeed, now the tasks are no longer deleted. But I discovered another problem.

For example, I added a description to a task. Then I open the description of this task again to edit it, to complete it. But when I open the description, it becomes empty and I have to write it again.

The same thing happens with subtasks.

UPD
I want to add a little bit to what I said above. I just noticed it now.

The description disappears in the plugin window, but the description remains in the task note (in the file itself).

Should I open a new Issue or just post here?

Thank you for your efforts!
I am following the development of this plugin with interest! 🙏

@TonyAtlas
Copy link
Author

The first picture is what the description and subtasks look like in view mode, and the second picture is the view in edit mode.

Pic_20250108_182037

Pic_20250108_182047

@tu2-atmanand
Copy link
Owner

tu2-atmanand commented Jan 8, 2025

I want to add a little bit to what I said above. I just noticed it now.

The description disappears in the plugin window, but the description remains in the task note (in the file itself).

Should I open a new Issue or just post here?

Yeah, actually this is a know issue. I also encountered it today only. What basically happening is. Since now I am using memoization concepts its optimizing too much, so the data in the UI do not changes for the Edit Task popup window. This will be fixed soon.

You can open a new issue, if possible. That will be great!

@tu2-atmanand
Copy link
Owner

tu2-atmanand commented Jan 8, 2025

The first picture is what the description and subtasks look like in view mode, and the second picture is the view in edit mode

Strange! why there is an empty line between Subtask 2 and Subtask 3. And before the "Example 1" lines?
Actually, you cannot use any empty lines inside the task body. The plugin will only consider the content as a part of the task body until it encounters an empty line.

Secondly, the tag is getting duplicated, because, since you added the tag before the pipe symbol, the plugin again created the tag when you edited the task using plugin. And then when it scanned the task third time, it found two tags in the task, which are exactly same. For now, you might need to put all the metadata after pipe symbol. After the #110 , you will be able to create the task as you want.

Lastly, I didnt understood, in Reading mode the tag was close to the pipe symbol, left to the due date. But in Live Editor mode, both the tags are visible and that too on the right side of the due date. If this is happening, this mostly will be due to Obsidian bug.

I also have reported, bug related to creating mult-indentation task body : https://forum.obsidian.md/t/data-hides-in-the-reading-mode-for-multi-level-indentation/90192?u=tu2_atmanand

@tu2-atmanand
Copy link
Owner

BTW, the following two things has been fixed :

  • The Edit Task popup window do not shows the updated task content, even though the task content has been updated in the Note.
  • There was another bug spawned, in a specific case, where the task body (sub-tasks + description ) lines were getting duplicated, when edited using the plugin.

These two fixed will be provided in the upcoming release.

This issue will be closed after this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready to Review
Development

No branches or pull requests

2 participants