Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] noBucket() method is not compatible with multiple mods #69

Open
cech12 opened this issue Aug 27, 2024 · 0 comments
Open

[1.20.1] noBucket() method is not compatible with multiple mods #69

cech12 opened this issue Aug 27, 2024 · 0 comments

Comments

@cech12
Copy link

cech12 commented Aug 27, 2024

Hello,

I am the developer of the BucketLib mod and a user opened an issue some days ago: cech12/BucketLib#45

There is a compatibility issue between my mod and Respiteful. This mod is registering fluids with your Registrate library and defines fluids without buckets:
https://github.com/DragonsPlusMinecraft/Respiteful/blob/660d4480dfe74a0a2e617c4858ea7a9b792b01ce/src/main/java/plus/dragons/respiteful/entries/RespitefulFluids.java#L113

My mod is calling the getBucket() method for each fluid to identify fluids with buckets. During that call, an item "mint_green_tea_bucket" is searched in the registry (by your implementation), which crashes the game, because this item does not exist. But it should not be searched when the fluid is initialized with noBucket().

The PR #55 should fix this issue, but nothing happens since a year, so I open this issue.

I hope this issue reaches to you and you can at least fix this problem. Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant