Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions not logged in RegistrateDataProvider #64

Open
mikerooni opened this issue Sep 9, 2023 · 0 comments
Open

Exceptions not logged in RegistrateDataProvider #64

mikerooni opened this issue Sep 9, 2023 · 0 comments

Comments

@mikerooni
Copy link

While debugging a hanging forge datagen process in GTCEu-Modern, we have discovered a case where exceptions are not logged (or at least not logged early enough).

In the following case, the RegistrateDataProvider hangs indefinitely without logging the underlying exception:

  • subProvider B depends on the output of subProvider A
  • subProvider A throws an exception, causing subProvider B not to complete

Here you can see the debugger view, the breakpoint is set at the returnStatement of RegistrateDataProvider#run:
image

The last subProvider ended up finishing normally afterwards, but the RegistrateItemTagsProvider depended on the RegistrateTagsProvider.IntrinsicImpl#IntrinsicImpl above it.

The following is a screenshot of the list to be used in the return statement:
image

You can see that list[4] is not completed, but depends on list[3], which had completed exceptionally.
This caused the datagen process to hang indefinitely, as the calling code was waiting for the RegistrateDataProvider to complete.

In case one of the subProviders fails, please consider logging the exception immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant