Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS with cert-manager #14

Open
andrestc opened this issue Apr 18, 2018 · 4 comments
Open

Add support for TLS with cert-manager #14

andrestc opened this issue Apr 18, 2018 · 4 comments

Comments

@andrestc
Copy link
Member

We added support for nginx + tls using kube-lego and its annotations in #11. Kube-lego is now deprecated and only supported in Kubernetes up to 1.8.x. We should add support for tls using cert-manager, which is the official replacement for kube-lego: https://github.com/jetstack/cert-manager/.

@gfleury
Copy link
Contributor

gfleury commented May 8, 2018

I've updated to cert-manager and update nginx-ingress (which already supports cert-manager).
The annotations are still the same for it:
kubernetes.io/tls-acme: true

But the point is that we have a few new annotations that can be used (besides the basic):

https://github.com/jetstack/cert-manager/blob/62c2fd8df9a8c8eaddd193fbfcd82269dc6836fe/docs/reference/ingress-shim.rst

I would say that certmanager.k8s.io/issuer and certmanager.k8s.io/cluster-issuer are nice ones to have handled by kubernetes-router.

@gfleury
Copy link
Contributor

gfleury commented May 8, 2018

Actually you can assign to me. =)

@andrestc
Copy link
Member Author

andrestc commented May 8, 2018

Look good. Maybe we can support receiving these as custom router options as well.

@gfleury
Copy link
Contributor

gfleury commented May 8, 2018

Sure, I will create a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants