Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow mods to setup links to other folders within the games path #57

Open
barkermn01 opened this issue Jan 27, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed priority/P2 only affects developers

Comments

@barkermn01
Copy link
Member

barkermn01 commented Jan 27, 2022

So it has been requested that we stop duplicating files inside mods (a reasonable request) to do this we need to look at setting up a link system in the mod.xml so a mod can register links.

Thinking something like

<Links>
    <Link src="$(GamePath)/somefile.jpg" des="${modPath}/somefile.jpg" />
</Link>

For security both src and destination will be barred from containing, ../, ./, : or starting with / this prevents people from making links outside of the game directory, it will also block links to .exe, .bat, .cmd, .msi or any other windows executable format (this should outright prevent the mods being loaded and tell the user why)

Need to make sure when parsing mod.xml we ignore links for IROs, as IROs are never extracted to the file system for use links won't work they are a file system, system, but maybe a system for the file loader to know that there is a link instead (more research required)

@barkermn01 barkermn01 added the Compatibility Problems with 3rd party software that need solving label Feb 2, 2022
@julianxhokaxhiu julianxhokaxhiu added the priority/P2 only affects developers label Mar 3, 2022
@julianxhokaxhiu julianxhokaxhiu added help wanted Extra attention is needed enhancement New feature or request and removed Compatibility Problems with 3rd party software that need solving labels Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed priority/P2 only affects developers
Projects
None yet
Development

No branches or pull requests

2 participants