Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument parsing is a mess. #131

Open
Archargelod opened this issue Oct 28, 2023 · 2 comments · May be fixed by #132
Open

Argument parsing is a mess. #131

Archargelod opened this issue Oct 28, 2023 · 2 comments · May be fixed by #132

Comments

@Archargelod
Copy link

Archargelod commented Oct 28, 2023 •
edited
Loading

I was inspecting your code to fix the "unreachable code" warning.
But honestly, you should just rewrite this part with std/parseopt

asOptionalParam() used once on a code that ALWAYS quits, so this part of template is completely useless:

        if paramVar.isNone:
          i += 1
        else:
          i += 2
@rexim
Copy link
Member

rexim commented Oct 28, 2023

Ah yes, my favorite genre of GitHub contributions. Patches through issues 5Head

@Archargelod Archargelod linked a pull request Oct 28, 2023 that will close this issue
Open
@Archargelod
Copy link
Author

Sorry, I've opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Warnings, use std/parseopt to parse cli arguments Archargelod/boomer
2 participants
@rexim @Archargelod