Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table row Iterator trait pattern should be a macro #146

Open
molpopgen opened this issue Jul 22, 2021 · 2 comments
Open

Table row Iterator trait pattern should be a macro #146

molpopgen opened this issue Jul 22, 2021 · 2 comments

Comments

@molpopgen
Copy link
Member

molpopgen commented Jul 22, 2021 •
edited
Loading

There's a good bit of code duplication implementing Iterator for all the Table/TableRef row types.
This implementation code should just be a macro: the types backing the iterators are only accessed by their Iterator behavior.
@molpopgen molpopgen added this to the 0.4.0 milestone Jul 28, 2021
@molpopgen
Copy link
Member Author

Can deal with this after #148?

@molpopgen molpopgen removed this from the 0.4.0 milestone Aug 31, 2021
@molpopgen
Copy link
Member Author

Removing this from 0.4.0 milestone: it is a back-end issue, and coupled with a tedious API issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen