-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ajv): add returnsCoercedValues option to keep the coerced value by ajv #2504
Conversation
@EinfachHans thanks for the PR. Just a small change to optimize the code ;) see you |
@Romakita okay somehow an integration test is now failing. Didn't know why it worked locally first... Anyways, the test that fails is |
Yes I take a look. This test is here to check if the null value is keep through after validation and deserialization depending on the endpoint configuration. |
Ok I already given information on this issue and why isn't fixable easily: |
Mhh, so should i close this PR? |
@EinfachHans I fixed the problem by introducing a new ajv options Can you review the latest commits please ;) |
This PR will solve your issue and another issue related to the coerced value by ajv! Good news :D |
@Romakita awesome, Thanks! 🚀 |
Ok fixed issue on my local. It should be ok to merge and release after that ;) |
🎉 This PR is included in version 7.43.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Information
closes #2497
With this PR the result of a Validation is correctly returned. The resulted data can be different from the input data, when the validation modifies it, which is a common usage.
This is my first PR to this awesome project. Please let me know if i'm missing something 🤔
Todos