Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump lerna from 4.0.0 to 7.4.1 #2475

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore(deps): bump lerna from 4.0.0 to 7.4.1 #2475

merged 1 commit into from
Oct 23, 2023

Conversation

Kit-p
Copy link
Contributor

@Kit-p Kit-p commented Oct 16, 2023

Closes: #2456

Information

Type Breaking change
Chore No

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Kit-p
Copy link
Contributor Author

Kit-p commented Oct 19, 2023

@Romakita The benchmark workflow is failing on the production branch as well, so I don't think my commit introduced the problem.

Please let me know when you plan to merge this, I can do a rebase to resolve the conflicts.

@Romakita
Copy link
Collaborator

No it’s normal. The gh token haven’t the correct scopes when the isn’t made by me ^^

@Romakita
Copy link
Collaborator

Ha no. This time is another issue ^^

@Kit-p Kit-p closed this Oct 21, 2023
@Kit-p Kit-p force-pushed the chore/upgrade-lerna-7 branch from c62c2c9 to cba2fc8 Compare October 21, 2023 16:02
@Kit-p
Copy link
Contributor Author

Kit-p commented Oct 21, 2023

@Romakita Sorry, accidentally closed the PR.
I have rebased and fixed the benchmark workflow error, would you please have a look?

@Kit-p Kit-p reopened this Oct 21, 2023
@Kit-p Kit-p changed the title chore(deps): bump lerna from 4.0.0 to 7.3.1 chore(deps): bump lerna from 4.0.0 to 7.4.1 Oct 21, 2023
@Romakita
Copy link
Collaborator

Yes I’ll merge the PR when the CI is ok ;)
Thanks for your PR @Kit-p

@Romakita Romakita merged commit 9989bcb into tsedio:production Oct 23, 2023
@Romakita
Copy link
Collaborator

@Kit-p done ;) thanks a lot for the PR!

@Kit-p
Copy link
Contributor Author

Kit-p commented Oct 23, 2023

Thank you for the review!

@Kit-p Kit-p deleted the chore/upgrade-lerna-7 branch October 23, 2023 06:20
@Romakita
Copy link
Collaborator

🎉 This PR is included in version 7.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romakita Romakita Romakita approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECH] Migrate to lerna 7
2 participants
@Kit-p @Romakita