Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade-out sound players even when idle or buffering #1157

Merged
merged 1 commit into from
Dec 31, 2023

fade-out sound players even when idle or buffering

46dd6c6
Select commit
Loading
Failed to load commit list.
Merged

Fade-out sound players even when idle or buffering #1157

fade-out sound players even when idle or buffering
46dd6c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 31, 2023 in 0s

29.66% (+0.32%) compared to 14aa445

View this Pull Request on Codecov

29.66% (+0.32%) compared to 14aa445

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (14aa445) 29.33% compared to head (46dd6c6) 29.66%.

Files Patch % Lines
...hub/ashutoshgngwr/noice/engine/LocalSoundPlayer.kt 0.00% 13 Missing ⚠️
...toshgngwr/noice/engine/media/DefaultMediaPlayer.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1157      +/-   ##
============================================
+ Coverage     29.33%   29.66%   +0.32%     
- Complexity      437      443       +6     
============================================
  Files           167      167              
  Lines          7090     7090              
  Branches        893      898       +5     
============================================
+ Hits           2080     2103      +23     
+ Misses         4684     4656      -28     
- Partials        326      331       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.